Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rendering files before compression #14

Open
fgutmann opened this issue Jun 27, 2011 · 2 comments
Open

rendering files before compression #14

fgutmann opened this issue Jun 27, 2011 · 2 comments

Comments

@fgutmann
Copy link

Hi Dirk,

we need to render some files with the template engine before compressing them.
I implemented a patch for this purpose, which we want to use internally for our project.

In our version the script, single-script, stylesheet and single-stylsheet tag support an option "render".
If it is true, the file is rendered using TemplateLoader before adding the source to the compressed file.

When press is disabled ("press.enabled=false"), files that need rendering are linked as "/press/[js|css]/rendered/". The corresponding action just renders the file and outputs it uncompressed.

The improvement is of limited use because you can't pass additional parameters to the template, but it is fine for our use case.
If you wan't this option in future press versions, I'm glad to send you a pull request.

Btw. what is the licence of the press module? Is it fine for you that we use a modified version? All changes are published in my press git repository.

Thanks,

Florian

@dirkmc
Copy link
Owner

dirkmc commented Jun 28, 2011

Hey Florian,
It's an interesting idea. I'm currently on site with a client but when I get back to Buenos Aires I'll take a look at it.
Thanks for the submission!
Dirk

@mhchan
Copy link

mhchan commented Nov 17, 2011

Any reason why this feature is not included in the latest version? Thanks

Simon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants