Skip to content
This repository was archived by the owner on Jan 6, 2023. It is now read-only.

Unable to remove unique on a field #1188

Open
jbalatero opened this issue Aug 11, 2019 · 14 comments
Open

Unable to remove unique on a field #1188

jbalatero opened this issue Aug 11, 2019 · 14 comments
Assignees
Labels
api bug Something isn't working

Comments

@jbalatero
Copy link

Steps to Reproduce

  • Fresh install of v2.4.0
  • Create a collection
  • Add a text field with unique enabled
  • Modify the text field to disable unique

Expected Behavior

The unique of field should be removed.

Actual Behavior

The field is still unique.

Other Context & Screenshots

Screen recording

Technical Details

  • Device: Desktop
  • OS: Win 10 10.0.18362.145
  • Web Server: Apache/2.4.29
  • PHP Version: PHP 7.1.30
  • Database: 10.2.26
  • Install Method: v2.4.0 build
  • Directus App: 7.9.0
@justrealmilk
Copy link

Try updating the field as you did, then refreshing the app before checking if it worked as expected. See what happens

@jbalatero
Copy link
Author

@justrealmilk I tried your suggestion in DIrectus demo, the same thing happens, it still unique.

@binal-7span binal-7span self-assigned this Aug 12, 2019
@binal-7span binal-7span added the bug Something isn't working label Aug 12, 2019
@binal-7span
Copy link
Contributor

Hey @jbaltero

This is a known issue of Zend DB that user is not able to remove the constraint. You can check here

@benhaynes

I think we should update our fork repo of Zend-DB.

@benhaynes
Copy link
Member

Hey @BJGajjar — any idea how complex this would be to update in our fork? I guess we would need to find out if this is just something they have "turned off" for some reason... or if it's a complex thing to get working.

@binal-7span
Copy link
Contributor

Hey @benhaynes

any idea how complex this would be to update in our fork?

It's not that much complex actually. But I need access to the repo.

I guess we would need to find out if this is just something they have "turned off" for some reason.

Don't worry. I'll check before update the code.

@benhaynes
Copy link
Member

Great, thanks @BJGajjar! I have given the API team admin access to the Zend fork.

https://github.com/directus/zend-db

@binal-7span
Copy link
Contributor

@benhaynes - This will be on hold until PR from Zend-DB is not getting merged.

I recommended some changes there. So we have to wait/develop it.

@benhaynes
Copy link
Member

Don't we have our own fork of that repo? I thought we did, but maybe I am mistaken.

@binal-7span
Copy link
Contributor

Don't we have our own fork of that repo?

Yes, we have a forked repo. But as Zend-DB don't have this feature yet. We need to develop it by our self in our fork repo.

@binal-7span
Copy link
Contributor

@benhaynes - Should we consider it a known issue or should we try to develop it?

I would like to mention here that we didn't take any decision yet for whether we should use fork repo or Zend-DB itself.

@benhaynes
Copy link
Member

Let's hold on this, I don't think we want to fork Zend... and this should be solved in the Laravel port. @rijkvanzanten @WoLfulus do you agree?

@rijkvanzanten
Copy link
Member

Zend-db is archived and no longer maintained, and it's a known issue in there. We rely on zend-db for our database abstraction layer. Once we're moved away from Zend-db, this issue will be resolved too.

@binal-7span
Copy link
Contributor

Once we're moved away from Zend-db, this issue will be resolved too.

Agree. So should we close this or still need to wait until we moved away from Zend?

@rijkvanzanten
Copy link
Member

Lets leave it open until we've migrated away from Zend, as it won't be fixed until we do

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants