Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cc signature checked twice in AcceptToMemoryPool #111

Open
dimxy opened this issue Apr 24, 2022 · 0 comments
Open

cc signature checked twice in AcceptToMemoryPool #111

dimxy opened this issue Apr 24, 2022 · 0 comments

Comments

@dimxy
Copy link
Owner

dimxy commented Apr 24, 2022

Cryptoconditions signature is checked twice in AcceptToMemoryPool()
Here:

if (!ContextualCheckInputs(tx, state, view, true, STANDARD_SCRIPT_VERIFY_FLAGS, true, txdata, Params().GetConsensus(), consensusBranchId, evalcodeChecker))

and here:

 if (!ContextualCheckInputs(tx, state, view, true, MANDATORY_SCRIPT_VERIFY_FLAGS, true, txdata, Params().GetConsensus(), consensusBranchId, evalcodeChecker))

I think it was supposed it is checked only at the call when STANDARD_SCRIPT_VERIFY_FLAGS is set when non-cc sigs are checked too.
Fix this to avoid extra processing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant