You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In my Ruby on Rails application, enable config.action_view.annotate_rendered_view_with_filenames which adds leading comments to the document. This shows the file path of the view partial rendered as a leading comment in the html.
When using Magnific popup with this enabled, it considers the target of the html being clicked to be the leading comment (which is the closest node) rather than the actual HTML element being clicked on.
This in turn makes the _checkIfClose() return true, because the target is not equal to the first item in mfp.content[0]
Desired:
MP ignores html comments and does not consider them a part of the content.
The text was updated successfully, but these errors were encountered:
Reproduction:
In my Ruby on Rails application, enable
config.action_view.annotate_rendered_view_with_filenames
which adds leading comments to the document. This shows the file path of the view partial rendered as a leading comment in the html.When using Magnific popup with this enabled, it considers the target of the html being clicked to be the leading comment (which is the closest node) rather than the actual HTML element being clicked on.
This in turn makes the
_checkIfClose()
return true, because the target is not equal to the first item inmfp.content[0]
Desired:
MP ignores html comments and does not consider them a part of the content.
The text was updated successfully, but these errors were encountered: