Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider %LocalAppData% for Windows #32

Open
dimo414 opened this issue Apr 27, 2023 · 0 comments
Open

Consider %LocalAppData% for Windows #32

dimo414 opened this issue Apr 27, 2023 · 0 comments

Comments

@dimo414
Copy link
Owner

dimo414 commented Apr 27, 2023

Currently bkt defaults to using the directory returned by std::env::temp_dir() on all platforms. In principle bkt should probably use a "user cache" directory instead, such as ProjectDirs::cache_dir - notably this would isolate cached data between users, which is currently a limitation we workaround on Unix with permissions.

However, in practice using temp_dir() is probably the best choice on Linux/OSX because we want to use a tempfs directory for performance. On Windows (to my knowledge) that isn't likely/possible so we might as well use %LocalAppData% instead which shouldn't be any slower than the Windows temp directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant