Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storeId to store import #1636

Open
Tracked by #1613
f1sh1918 opened this issue Sep 13, 2024 · 2 comments
Open
Tracked by #1613

Add storeId to store import #1636

f1sh1918 opened this issue Sep 13, 2024 · 2 comments
Labels
discussion-needed We need to resolve the questions in the issue. Task

Comments

@f1sh1918
Copy link
Contributor

Is your feature request related to a problem? Please describe.
To ensure that we have reliable and constant store ids, we have to provide them in the csv instead of identify a stores with name and address. Since the address may change f.e. if the store moves then currently the store will be deleted and a new store will be created even it is the same store

Describe the solution you'd like

  • add a storeId to the csv
  • display this storeId in the table
  • add the store id to the storeConfig and make it mandatory
  • check that the storeId is unique
  • add the storeId field to the database table
  • use the storeId to update stores
@f1sh1918
Copy link
Contributor Author

f1sh1918 commented Oct 2, 2024

@seluianova
what we could also do is. If there is a store entry without a storeId, we create a uniqueStore id and push it to the database.
Since there is a csv export function planned, we could then export this storeId and use this file for the next import.

@seluianova
Copy link
Contributor

@f1sh1918
how will we update the list of accepting stores? for example, if new stores are added?
I assumed, not manually, but this csv for upload will be generated somehow from some other source?
if I understand correctly, and we do what you suggest, we will have to somehow merge our generated identifiers with externally provided identifiers...

maybe we should add an additional nullable column - externalId.
if provided - we will use it to manage favorites, update stores during import, etc.
if not provided - keep the current logic

@ztefanie ztefanie added the discussion-needed We need to resolve the questions in the issue. label Oct 15, 2024
@ztefanie ztefanie removed this from the Koblenz Pass milestone Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion-needed We need to resolve the questions in the issue. Task
Projects
Status: No status
Status: No status
Development

No branches or pull requests

3 participants