From 0279afe60ebb2b42548a62f92e0b71dbba7ee280 Mon Sep 17 00:00:00 2001 From: pavelvais Date: Mon, 3 Feb 2025 15:52:47 +0100 Subject: [PATCH] Renamed MultiSing into BulkSignature --- CHANGELOG.md | 6 ++--- src/DigiSign.php | 6 ++--- src/Endpoint/BatchSendingsEndpoint.php | 10 ++++----- ...Endpoint.php => BulkSignatureEndpoint.php} | 8 +++---- src/Resource/AccountBilling.php | 2 +- .../{MultiSign.php => BulkSignature.php} | 2 +- ...nfo.php => BulkSignatureRecipientInfo.php} | 4 ++-- tests/DigiSignTest.php | 4 ++-- tests/Endpoint/BatchSendingEndpointTest.php | 6 ++--- tests/Endpoint/BulkSignatureEndpointTest.php | 22 +++++++++++++++++++ tests/Endpoint/MultiSignEndpointTest.php | 22 ------------------- 11 files changed, 46 insertions(+), 46 deletions(-) rename src/Endpoint/{MultiSignEndpoint.php => BulkSignatureEndpoint.php} (53%) rename src/Resource/{MultiSign.php => BulkSignature.php} (95%) rename src/Resource/{MultiSignRecipientInfo.php => BulkSignatureRecipientInfo.php} (67%) create mode 100644 tests/Endpoint/BulkSignatureEndpointTest.php delete mode 100644 tests/Endpoint/MultiSignEndpointTest.php diff --git a/CHANGELOG.md b/CHANGELOG.md index c18cfde..430550d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,8 +8,8 @@ Updates should follow the [Keep a CHANGELOG](http://keepachangelog.com/) princip - Edit `AccountGuide.settingsFilled` - Add `MyPreferences.guideHide` - Add `Account.guide` endpoint and `AccountGuide` resource -- Add `AccountBilling.multiSign` -- Edit `MultiSignRecipientInfo` resource +- Add `AccountBilling.bulkSigning` +- Edit `BulkSignatureRecipientInfo` resource - Add `BatchSendingsEndpoint.MutiSignRecipients` endpoint - Add `MyEndpoint.updatePreferences` endpoint and `MyPreferences` resource - Add `SignatureScenarioVersionInfo.role` @@ -28,7 +28,7 @@ Updates should follow the [Keep a CHANGELOG](http://keepachangelog.com/) princip - Add `AccountEndpoint.createDefaultSubscription` endpoint - Add `SignatureScenario.latestVersionInfo` - Add `EnvelopeTemplateTag`.`customIdentifier` in to resource -- Add `MultiSign.get` endpoint +- Add `BulkSignature.get` endpoint ## [2.5.0] - 2024-10-14 - Add `AccountBilling.automaticTagsPlacement` diff --git a/src/DigiSign.php b/src/DigiSign.php index fc4f5c6..4acb8fb 100644 --- a/src/DigiSign.php +++ b/src/DigiSign.php @@ -10,6 +10,7 @@ use DigitalCz\DigiSign\Endpoint\AccountEndpoint; use DigitalCz\DigiSign\Endpoint\AuthEndpoint; use DigitalCz\DigiSign\Endpoint\BatchSendingsEndpoint; +use DigitalCz\DigiSign\Endpoint\BulkSignatureEndpoint; use DigitalCz\DigiSign\Endpoint\DeliveriesEndpoint; use DigitalCz\DigiSign\Endpoint\EndpointInterface; use DigitalCz\DigiSign\Endpoint\EnumsEndpoint; @@ -19,7 +20,6 @@ use DigitalCz\DigiSign\Endpoint\IdentificationsEndpoint; use DigitalCz\DigiSign\Endpoint\ImagesEndpoint; use DigitalCz\DigiSign\Endpoint\LabelsEndpoint; -use DigitalCz\DigiSign\Endpoint\MultiSignEndpoint; use DigitalCz\DigiSign\Endpoint\MyEndpoint; use DigitalCz\DigiSign\Endpoint\ReportEndpoint; use DigitalCz\DigiSign\Endpoint\WebhooksEndpoint; @@ -290,9 +290,9 @@ public function report(): ReportEndpoint return new ReportEndpoint($this); } - public function multiSign(): MultiSignEndpoint + public function bulkSignature(): BulkSignatureEndpoint { - return new MultiSignEndpoint($this); + return new BulkSignatureEndpoint($this); } private function createUserAgent(): string diff --git a/src/Endpoint/BatchSendingsEndpoint.php b/src/Endpoint/BatchSendingsEndpoint.php index 991b6cd..d42efd1 100644 --- a/src/Endpoint/BatchSendingsEndpoint.php +++ b/src/Endpoint/BatchSendingsEndpoint.php @@ -13,9 +13,9 @@ use DigitalCz\DigiSign\Resource\BaseResource; use DigitalCz\DigiSign\Resource\BatchSending; use DigitalCz\DigiSign\Resource\BatchSendingStats; +use DigitalCz\DigiSign\Resource\BulkSignatureRecipientInfo; use DigitalCz\DigiSign\Resource\Collection; use DigitalCz\DigiSign\Resource\ListResource; -use DigitalCz\DigiSign\Resource\MultiSignRecipientInfo; /** * @extends ResourceEndpoint @@ -55,13 +55,13 @@ public function stats(BatchSending|string $id): BatchSendingStats } /** - * @return Collection + * @return Collection */ - public function multiSignRecipients(BatchSending|string $id): Collection + public function bulkSignatureRecipients(BatchSending|string $id): Collection { return $this->createCollectionResource( - $this->getRequest('/{id}/multi-sign-recipients', ['id' => $id]), - MultiSignRecipientInfo::class, + $this->getRequest('/{id}/bulk-signature-recipients', ['id' => $id]), + BulkSignatureRecipientInfo::class, ); } } diff --git a/src/Endpoint/MultiSignEndpoint.php b/src/Endpoint/BulkSignatureEndpoint.php similarity index 53% rename from src/Endpoint/MultiSignEndpoint.php rename to src/Endpoint/BulkSignatureEndpoint.php index 5c32184..b71396b 100644 --- a/src/Endpoint/MultiSignEndpoint.php +++ b/src/Endpoint/BulkSignatureEndpoint.php @@ -6,17 +6,17 @@ use DigitalCz\DigiSign\DigiSign; use DigitalCz\DigiSign\Endpoint\Traits\GetEndpointTrait; -use DigitalCz\DigiSign\Resource\MultiSign; +use DigitalCz\DigiSign\Resource\BulkSignature; /** - * @extends ResourceEndpoint + * @extends ResourceEndpoint */ -final class MultiSignEndpoint extends ResourceEndpoint +final class BulkSignatureEndpoint extends ResourceEndpoint { use GetEndpointTrait; public function __construct(DigiSign $parent) { - parent::__construct($parent, '/api/multi-signs', MultiSign::class); + parent::__construct($parent, '/api/bulk-signatures', BulkSignature::class); } } diff --git a/src/Resource/AccountBilling.php b/src/Resource/AccountBilling.php index f005c0b..a8226b6 100644 --- a/src/Resource/AccountBilling.php +++ b/src/Resource/AccountBilling.php @@ -66,5 +66,5 @@ class AccountBilling extends BaseResource public bool $automaticTagsPlacement; - public bool $multiSign; + public bool $bulkSigning; } diff --git a/src/Resource/MultiSign.php b/src/Resource/BulkSignature.php similarity index 95% rename from src/Resource/MultiSign.php rename to src/Resource/BulkSignature.php index 0e287f3..1704ff8 100644 --- a/src/Resource/MultiSign.php +++ b/src/Resource/BulkSignature.php @@ -7,7 +7,7 @@ use DateTime; use DigitalCz\DigiSign\Resource\Traits\EntityResourceTrait; -final class MultiSign extends BaseResource +final class BulkSignature extends BaseResource { use EntityResourceTrait; diff --git a/src/Resource/MultiSignRecipientInfo.php b/src/Resource/BulkSignatureRecipientInfo.php similarity index 67% rename from src/Resource/MultiSignRecipientInfo.php rename to src/Resource/BulkSignatureRecipientInfo.php index b2981fb..5c43e40 100644 --- a/src/Resource/MultiSignRecipientInfo.php +++ b/src/Resource/BulkSignatureRecipientInfo.php @@ -4,7 +4,7 @@ namespace DigitalCz\DigiSign\Resource; -class MultiSignRecipientInfo extends BaseResource +class BulkSignatureRecipientInfo extends BaseResource { public string $name; @@ -14,5 +14,5 @@ class MultiSignRecipientInfo extends BaseResource public int $count; - public bool $isMultiSignable; + public bool $isBulkSignable; } diff --git a/tests/DigiSignTest.php b/tests/DigiSignTest.php index 1512b1c..9d74258 100644 --- a/tests/DigiSignTest.php +++ b/tests/DigiSignTest.php @@ -156,8 +156,8 @@ public function testChildren(): void self::assertSame('/api/my', $mockClient->getLastRequest()->getUri()->getPath()); $dgs->report()->request('GET'); self::assertSame('/api/report', $mockClient->getLastRequest()->getUri()->getPath()); - $dgs->multiSign()->request('GET'); - self::assertSame('/api/multi-signs', $mockClient->getLastRequest()->getUri()->getPath()); + $dgs->bulkSignature()->request('GET'); + self::assertSame('/api/bulk-signatures', $mockClient->getLastRequest()->getUri()->getPath()); } public function testUserAgent(): void diff --git a/tests/Endpoint/BatchSendingEndpointTest.php b/tests/Endpoint/BatchSendingEndpointTest.php index 4877bd6..a326814 100644 --- a/tests/Endpoint/BatchSendingEndpointTest.php +++ b/tests/Endpoint/BatchSendingEndpointTest.php @@ -31,10 +31,10 @@ public function testStats(): void self::assertLastRequest('GET', "/api/batch-sendings/foo/stats"); } - public function testMultiSignRecipients(): void + public function testBulkSignatureRecipients(): void { - self::endpoint()->multiSignRecipients('foo'); - self::assertLastRequest('GET', "/api/batch-sendings/foo/multi-sign-recipients"); + self::endpoint()->bulkSignatureRecipients('foo'); + self::assertLastRequest('GET', "/api/batch-sendings/foo/bulk-signature-recipients"); } protected static function endpoint(): BatchSendingsEndpoint diff --git a/tests/Endpoint/BulkSignatureEndpointTest.php b/tests/Endpoint/BulkSignatureEndpointTest.php new file mode 100644 index 0000000..e899581 --- /dev/null +++ b/tests/Endpoint/BulkSignatureEndpointTest.php @@ -0,0 +1,22 @@ +get('foo'); + self::assertLastRequest('GET', '/api/bulk-signatures/foo'); + } + + protected static function endpoint(): BulkSignatureEndpoint + { + return self::dgs()->bulkSignature(); + } +} diff --git a/tests/Endpoint/MultiSignEndpointTest.php b/tests/Endpoint/MultiSignEndpointTest.php deleted file mode 100644 index 5f433ec..0000000 --- a/tests/Endpoint/MultiSignEndpointTest.php +++ /dev/null @@ -1,22 +0,0 @@ -get('foo'); - self::assertLastRequest('GET', '/api/multi-signs/foo'); - } - - protected static function endpoint(): MultiSignEndpoint - { - return self::dgs()->multiSign(); - } -}