Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website theme only changes are ignored for deployment #758

Open
yves-da opened this issue Jul 16, 2024 · 0 comments
Open

Website theme only changes are ignored for deployment #758

yves-da opened this issue Jul 16, 2024 · 0 comments
Labels
bug Something isn't working deployment

Comments

@yves-da
Copy link
Contributor

yves-da commented Jul 16, 2024

Problem

This PR #754 changed only content in the theme directory, but that change did not get pushed to docs.daml.com.

Workaround

The theme changes were then pushed to docs.daml.com by means of small documentation changes, see #755 and #757.

Analysis

On CI, the push_docs job didn't deploy to docs.daml.com with the following output:

2.10.0 is up-to-date, nothing to do.
2.3.20 is up-to-date, nothing to do.
2.7.9 is up-to-date, nothing to do.
2.8.9 is up-to-date, nothing to do.
2.9.0 is up-to-date, nothing to do.
3.1 is up-to-date, nothing to do.
draft is up-to-date, nothing to do.
root is up-to-date (2.8.9, a4fb2f8e136bc6811883dd3d8c3f23251a8268ba).
snapshots.json is up-to-date.
versions.json is up-to-date.
/downloads up-to-date, nothing to do

The push_docs job has got a change detection logic which does not trigger on theme directory only changes.
https://github.com/digital-asset/docs.daml.com/blob/main/.circleci/config.yml#L163

Solution idea

Add the theme to the sha logic, that is don't take the latest commit that touched a folder, but the latest that touched a folder or theme.

@yves-da yves-da added bug Something isn't working deployment labels Jul 16, 2024
@yves-da yves-da changed the title Website ***theme only changes*** are ignored for deployment Website theme only changes are ignored for deployment Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working deployment
Projects
None yet
Development

No branches or pull requests

1 participant