Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unserializable types have upgrade invariants enforced on them #19530

Open
dylant-da opened this issue Jul 8, 2024 · 0 comments · May be fixed by #19625
Open

Unserializable types have upgrade invariants enforced on them #19530

dylant-da opened this issue Jul 8, 2024 · 0 comments · May be fixed by #19625
Assignees

Comments

@dylant-da
Copy link
Contributor

Unserializable data types could in theory be able to change to whatever they like, since they will never to be committed to the ledger in a way that is interacted with other packages.

Currently, we enforce the normal upgrade rules even on unserializable types.

At the same time, it may be best to disallow changing unserializable data types - gives us a lot more freedom to define a good upgrade semantics for unserializable types in the future.

At the very least we should do a serializability check and disallow upgrade logic on unserializable types.

@dylant-da dylant-da self-assigned this Jul 15, 2024
@dylant-da dylant-da linked a pull request Jul 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant