Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove browserify-shim dependency #11

Open
jefbarn opened this issue Aug 9, 2016 · 2 comments
Open

Remove browserify-shim dependency #11

jefbarn opened this issue Aug 9, 2016 · 2 comments

Comments

@jefbarn
Copy link

jefbarn commented Aug 9, 2016

There's no need to force browserify (browserify-shim specifically) in the dependencies. Causes annoying errors and warnings for projects using alternative bundlers (webpack) and polyfills (core-js).

@gmaclennan
Copy link
Member

This exists so that the packaged version does not include the Leaflet code. I would welcome any PR that makes this work with other bundlers. I don't use them so I would not know where to start.

@mchlroy
Copy link

mchlroy commented Jun 28, 2021

I'm having the same problem. I have warning telling me to install browserify >= 2.3 because browserify-shim depends on it.

Correct me if I'm wrong, but I shouldn't need to have browserify-shim installed at all if I'm simply using your package along with leaflet, can't it simply be moved into the devDependencies? Even the browserify-shim README states to install it in devDependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants