Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security risk? #3

Open
kamilafsar opened this issue Jul 1, 2013 · 2 comments
Open

Security risk? #3

kamilafsar opened this issue Jul 1, 2013 · 2 comments

Comments

@kamilafsar
Copy link

Hey there,

Thanks for your excellent work. I think I'm going to use this in my project.

I may be wrong but I think exposing the width/height parameters as a path/qs param is a security risk. One could for instance write a simple script which causes a DoS by letting it resize an asset in many many width/height formats.

You may be aware of this, but someone else maybe not. So I wouldn't encourage usages like that in the sample app.

Just a simple thought.

Cheers,
Kamil

@leon
Copy link
Contributor

leon commented Jul 2, 2013

That's a valid point.
A solution would be to add all the resolutions that are allowed to the configuration section.
Feel free to submit a pull request, if you feel up to it :)

@sh1ng
Copy link

sh1ng commented Jun 23, 2014

you may add simple route with predefined resolutions
GET /res/profile/:file se.digiplant.scalr.ScalrResAssets.at(file, width: Int = 200, height: Int = 200, source: String = "profile")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants