Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable commentOps on merged PRs ⚠️ #1666

Open
raouf-xh opened this issue Aug 14, 2024 · 1 comment
Open

Disable commentOps on merged PRs ⚠️ #1666

raouf-xh opened this issue Aug 14, 2024 · 1 comment

Comments

@raouf-xh
Copy link
Contributor

We noticed that Digger backend can still get triggered using commentOps on old merged PRs.

If the merged PRs feature branches are deleted, the backend is not able to read digger.yml (that's fine)

However, when restoring the branch, we can trigger the backend with digger plan or digger apply and it will run successfully, the output will then show that resources will be destroyed which is expected since the old branch doesn't have the latest resources in the main branch. Moreover, digger apply can be run without any restrictions.

This is bad and a serious issue as it can result in the destruction of existing infrastructure

@motatoes
Copy link
Contributor

motatoes commented Aug 14, 2024

Hi @raouf-xh for future viewer context you have been onboarded onto next.digger.dev which has a flow of apply after merge by default. Please note that if you move to this repo you need to ensure to uninstall the community edition github app since the new team UI gh app would have been installed on the same repository

We will try to do a better job of explaining it in the next.digger.dev UI. Please let me know if it resolves your issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants