Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.5.1 release issues overview #143

Open
8 of 12 tasks
bobleesj opened this issue Oct 30, 2024 · 13 comments
Open
8 of 12 tasks

3.5.1 release issues overview #143

bobleesj opened this issue Oct 30, 2024 · 13 comments

Comments

@bobleesj
Copy link
Contributor Author

bobleesj commented Nov 6, 2024

@alisnwu, I saw lots of PRs today—thanks! Just wondering if there are any issues here, besides #138, that you would need further discussions?

@alisnwu
Copy link

alisnwu commented Nov 6, 2024

@bobleesj I think everything is good so far! I made edits to #140 and #129 based on simon's comments and #137 should be done after #138 is decided. I believe #144 is just waiting to be merged

@bobleesj
Copy link
Contributor Author

bobleesj commented Nov 6, 2024

Thanks for the update. Just resolved the bottleneck for #138: #138 (comment)

@bobleesj
Copy link
Contributor Author

bobleesj commented Nov 8, 2024

@alisnwu Would it be possible to do the 3.5.1 checklist tomorrow? I think #158 needs to be into a new PR as requested. Thanks a lot for your hard work.

@alisnwu
Copy link

alisnwu commented Nov 8, 2024

Yep sounds good, I will make a new PR for that tonight

@bobleesj
Copy link
Contributor Author

bobleesj commented Nov 9, 2024

@alisnwu almost there! great progress.

@sbillinge
Copy link
Contributor

@alisnwu I merged the other PR that previously had all the function name changes.

We will need a new PR where we deprecate Diffraction_object in favor of DiffractionObject.

Let's do that one as a practice. We can tackle loadData later if we want to, so for now just leave that as it is. You would normally deprecate something for two mid-level release numbers at least.

@bobleesj
Copy link
Contributor Author

#165

@alisnwu Just to make sure, the deprecation task is handled in the PR above to to set a standard where we can build upon.

@bobleesj
Copy link
Contributor Author

@alisnwu Would you make a PR for the one remaining issue above?

@bobleesj
Copy link
Contributor Author

@alisnwu Alison, I've noticed this PR is created #169 by @Sparks29032

What's going on? Does it close #137 ?

@alisnwu
Copy link

alisnwu commented Nov 12, 2024

@bobleesj Andrew was not experiencing the errors from sphinx that I was on his local, so this would PR should close #137

@bobleesj
Copy link
Contributor Author

Will you be making the release checklist, @alisnwu? Ideally, we need some buffer time before tomorrow's group meeting to test the package (Please see the checklist). We should probably do it this morning or early afternoon latest to make it realistic, since @sbillinge needs to release packages manually.

@alisnwu
Copy link

alisnwu commented Nov 13, 2024

@bobleesj Yep, already made the checklist. However, still need to check off the new tasks in the 3.5.1 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants