Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compute_cve replace the interpolation step #94

Open
yucongalicechen opened this issue Sep 5, 2024 · 2 comments
Open

compute_cve replace the interpolation step #94

yucongalicechen opened this issue Sep 5, 2024 · 2 comments
Milestone
0.2.1 release

Comments

@yucongalicechen
Copy link
Collaborator

yucongalicechen commented Sep 5, 2024 •
edited
Loading

We have an issue in diffpy.utils (diffpy/diffpy.utils#48) that interpolate onto different grids in the DO itself. If that ever gets implemented, we want to replace the related steps in the compute_cve function in functions.py (see discussions in #92 and #87 for more detail).
@sbillinge
Copy link
Contributor

@yucongalicechen please review and close if necessary

@sbillinge sbillinge added this to the 0.2.1 release milestone Oct 26, 2024
@yucongalicechen
Copy link
Collaborator Author

@yucongalicechen please review and close if necessary

I don't think this can be closed now. I updated the description to make it clearer.

@yucongalicechen yucongalicechen mentioned this issue Nov 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2.1 release
Development

No branches or pull requests
2 participants
@sbillinge @yucongalicechen