Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change how Shells are opened #4

Open
nedtwigg opened this issue Apr 26, 2019 · 0 comments
Open

Change how Shells are opened #4

nedtwigg opened this issue Apr 26, 2019 · 0 comments
Milestone
4.x

Comments

@nedtwigg
Copy link
Member

It should be possible to create a shell without opening it. It's also not clear that the andBlock methods are a good idea. We should look at where it is used in our code, and see how many would be better as just regular open.

We could decrease the API size if all of the openOnXX instead became just createOn(). Then you could call open when/if you wanted.
@nedtwigg nedtwigg added this to the 4.x milestone Apr 26, 2019
@nedtwigg nedtwigg changed the title Change how Shellls are opened Change how Shells are opened Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.x
Development

No branches or pull requests
1 participant
@nedtwigg