Skip to content

Commit 69169d1

Browse files
kroeningkroening
authored
Merge pull request #8226 from diffblue/fatal-assertions
introduce 'fatal assertions'
2 parents 41496b9 + 3cdd832 commit 69169d1

File tree

11 files changed

+264
-16
lines changed

11 files changed

+264
-16
lines changed

‎regression/cbmc-incr-smt2/bitvector-flag-tests/div_by_zero.desc

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ CORE
22
div_by_zero.c
33
--div-by-zero-check --trace
44
\[main\.division-by-zero\.1\] line \d division by zero in x / y: FAILURE
5-
\[main\.division-by-zero\.2\] line \d+ division by zero in x / z: SUCCESS
5+
\[main\.division-by-zero\.2\] line \d+ division by zero in x / z: UNKNOWN
66
y=0
77
^VERIFICATION FAILED$
88
^EXIT=10$

‎regression/cbmc/Division3/main.c

+18
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
_Bool nondet_bool();
2+
3+
void main()
4+
{
5+
__CPROVER_assert(0, "non-fatal assertion");
6+
7+
if(nondet_bool())
8+
{
9+
int divisor = nondet_bool() ? 2 : 0;
10+
11+
// possible division by zero
12+
int result = 10 / divisor;
13+
14+
__CPROVER_assert(divisor == 2 || divisor == 0, "divisor value");
15+
}
16+
else
17+
__CPROVER_assert(0, "independent assertion");
18+
}

‎regression/cbmc/Division3/test.desc

+13
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
CORE
2+
main.c
3+
4+
^EXIT=10$
5+
^SIGNAL=0$
6+
^\[main\.assertion\.1\] line 5 non-fatal assertion: FAILURE$
7+
^\[main\.division-by-zero\.1\] line 12 division by zero in 10 / divisor: FAILURE$
8+
^\[main\.assertion\.2\] line 14 divisor value: UNKNOWN$
9+
^\[main\.assertion\.3\] line 17 independent assertion: FAILURE$
10+
^\*\* 3 of 4 failed
11+
^VERIFICATION FAILED$
12+
--
13+
^warning: ignoring

‎regression/cbmc/pragma_cprover_enable_all/test.desc

+13-13
Original file line numberDiff line numberDiff line change
@@ -8,22 +8,22 @@ main.c
88
^\[main\.float-division-by-zero\.\d+\] line 87 floating-point division by zero in x / den: FAILURE
99
^\[main\.overflow\.\d+\] line 87 arithmetic overflow on floating-point division in x / den: FAILURE
1010
^\[main\.division-by-zero\.\d+\] line 88 division by zero in 10 / 0: FAILURE$
11-
^\[main\.enum-range-check\.\d+\] line 89 enum range check in \(ABC\)10: FAILURE
12-
^\[main\.overflow\.\d+\] line 90 arithmetic overflow on signed (to unsigned )?type conversion in \(char\)\(\(signed int\)i \+ 1\): FAILURE
13-
^\[main\.overflow\.\d+\] line 91 arithmetic overflow on signed \+ in k \+ 1: FAILURE
11+
^\[main\.enum-range-check\.\d+\] line 89 enum range check in \(ABC\)10: FAILURE$
12+
^\[main\.overflow\.\d+\] line 90 arithmetic overflow on signed (to unsigned )?type conversion in \(char\)\(\(signed int\)i \+ 1\): FAILURE$
13+
^\[main\.overflow\.\d+\] line 91 arithmetic overflow on signed \+ in k \+ 1: FAILURE$
1414
^VERIFICATION FAILED$
1515
^EXIT=10$
1616
^SIGNAL=0$
1717
--
18-
^\[main\.pointer_primitives\.\d+\] line 41 pointer invalid in R_OK\(q, \(unsigned (long (long )?)?int\)1\): FAILURE$
19-
^\[main\.pointer_primitives\.\d+\] line 41 pointer outside object bounds in R_OK\(q, \(unsigned (long (long )?)?int\)1\): FAILURE$
20-
^\[main\.pointer_arithmetic\.\d+\] line 42 pointer arithmetic: pointer outside object bounds in p \+ .*2000000000000(l|ll): FAILURE
21-
^\[main\.NaN\.\d+\] line 48 NaN on / in x / den: FAILURE
22-
^\[main\.float-division-by-zero\.\d+\] line 49 floating-point division by zero in x / den: FAILURE
23-
^\[main\.overflow\.\d+\] line 48 arithmetic overflow on floating-point division in x / den: FAILURE
24-
^\[main\.division-by-zero\.\d+\] line 48 division by zero in 10 / 0: FAILURE$
25-
^\[main\.enum-range-check\.\d+\] line 49 enum range check in \(ABC\)10: FAILURE
26-
^\[main\.overflow\.\d+\] line 50 arithmetic overflow on signed type conversion in \(char\)\(signed int\)i \+ 1\): FAILURE
27-
^\[main\.overflow\.\d+\] line 51 arithmetic overflow on signed \+ in k \+ 1: FAILURE
18+
^\[main\.pointer_primitives\.\d+\] line 41 pointer invalid in R_OK\(q, \(unsigned (long (long )?)?int\)1\):
19+
^\[main\.pointer_primitives\.\d+\] line 41 pointer outside object bounds in R_OK\(q, \(unsigned (long (long )?)?int\)1\):
20+
^\[main\.pointer_arithmetic\.\d+\] line 42 pointer arithmetic: pointer outside object bounds in p \+ .*2000000000000(l|ll):
21+
^\[main\.NaN\.\d+\] line 48 NaN on / in x / den:
22+
^\[main\.float-division-by-zero\.\d+\] line 49 floating-point division by zero in x / den:
23+
^\[main\.overflow\.\d+\] line 48 arithmetic overflow on floating-point division in x / den:
24+
^\[main\.division-by-zero\.\d+\] line 48 division by zero in 10 / 0:
25+
^\[main\.enum-range-check\.\d+\] line 49 enum range check in \(ABC\)10:
26+
^\[main\.overflow\.\d+\] line 50 arithmetic overflow on signed type conversion in \(char\)\(signed int\)i \+ 1\):
27+
^\[main\.overflow\.\d+\] line 51 arithmetic overflow on signed \+ in k \+ 1:
2828
--
2929
This test uses all possible named-checks to maximize coverage.

‎src/ansi-c/goto_check_c.cpp

+3
Original file line numberDiff line numberDiff line change
@@ -1752,6 +1752,9 @@ void goto_check_ct::add_guarded_property(
17521752
}
17531753
else
17541754
{
1755+
if(property_class == "division-by-zero")
1756+
annotated_location.property_fatal(true);
1757+
17551758
new_code.add(goto_programt::make_assertion(
17561759
std::move(guarded_expr), annotated_location));
17571760
}

‎src/goto-checker/Makefile

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
11
SRC = bmc_util.cpp \
22
counterexample_beautification.cpp \
33
cover_goals_report_util.cpp \
4-
incremental_goto_checker.cpp \
4+
fatal_assertions.cpp \
55
goto_symex_fault_localizer.cpp \
66
goto_symex_property_decider.cpp \
77
goto_trace_storage.cpp \
88
goto_verifier.cpp \
9+
incremental_goto_checker.cpp \
910
multi_path_symex_checker.cpp \
1011
multi_path_symex_only_checker.cpp \
1112
properties.cpp \

‎src/goto-checker/all_properties_verifier_with_trace_storage.h

+5-1
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,12 @@ Author: Daniel Kroening, Peter Schrammel
1212
#ifndef CPROVER_GOTO_CHECKER_ALL_PROPERTIES_VERIFIER_WITH_TRACE_STORAGE_H
1313
#define CPROVER_GOTO_CHECKER_ALL_PROPERTIES_VERIFIER_WITH_TRACE_STORAGE_H
1414

15-
#include "goto_verifier.h"
15+
#include <goto-programs/abstract_goto_model.h>
1616

1717
#include "bmc_util.h"
18+
#include "fatal_assertions.h"
1819
#include "goto_trace_storage.h"
20+
#include "goto_verifier.h"
1921
#include "incremental_goto_checker.h"
2022
#include "properties.h"
2123
#include "report_util.h"
@@ -62,6 +64,8 @@ class all_properties_verifier_with_trace_storaget : public goto_verifiert
6264
++iterations;
6365
}
6466

67+
propagate_fatal_assertions(properties, goto_model.get_goto_functions());
68+
6569
return determine_result(properties);
6670
}
6771

‎src/goto-checker/fatal_assertions.cpp

+172
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,172 @@
1+
/*******************************************************************\
2+
3+
Module: Fatal Assertions
4+
5+
Author: Daniel Kroening, [email protected]
6+
7+
\*******************************************************************/
8+
9+
/// \file
10+
/// Fatal Assertions
11+
12+
#include "fatal_assertions.h"
13+
14+
#include <util/irep_hash.h>
15+
16+
#include <goto-programs/goto_functions.h>
17+
18+
#include <stack>
19+
#include <unordered_set>
20+
21+
struct function_loc_pairt
22+
{
23+
using function_itt = goto_functionst::function_mapt::const_iterator;
24+
function_loc_pairt(
25+
function_itt __function_it,
26+
goto_programt::const_targett __target)
27+
: function_it(__function_it), target(__target)
28+
{
29+
}
30+
function_itt function_it;
31+
goto_programt::const_targett target;
32+
bool operator==(const function_loc_pairt &other) const
33+
{
34+
return function_it->first == other.function_it->first &&
35+
target == other.target;
36+
}
37+
};
38+
39+
struct function_itt_hasht
40+
{
41+
using function_itt = goto_functionst::function_mapt::const_iterator;
42+
std::size_t operator()(const function_itt &function_it) const
43+
{
44+
return function_it->first.hash();
45+
}
46+
};
47+
48+
struct function_loc_pair_hasht
49+
{
50+
std::size_t operator()(const function_loc_pairt &p) const
51+
{
52+
auto h1 = p.function_it->first.hash();
53+
auto h2 = const_target_hash{}(p.target);
54+
return hash_combine(h1, h2);
55+
}
56+
};
57+
58+
using loc_sett =
59+
std::unordered_set<function_loc_pairt, function_loc_pair_hasht>;
60+
61+
static loc_sett
62+
reachable_fixpoint(const loc_sett &locs, const goto_functionst &goto_functions)
63+
{
64+
// frontier set
65+
std::stack<function_loc_pairt> working;
66+
67+
for(auto loc : locs)
68+
working.push(loc);
69+
70+
loc_sett fixpoint;
71+
72+
while(!working.empty())
73+
{
74+
auto loc = working.top();
75+
working.pop();
76+
77+
auto insertion_result = fixpoint.insert(loc);
78+
if(!insertion_result.second)
79+
continue; // seen already
80+
81+
if(loc.target->is_function_call())
82+
{
83+
// get the callee
84+
auto &function = loc.target->call_function();
85+
if(function.id() == ID_symbol)
86+
{
87+
// add the callee to the working set
88+
auto &function_identifier = to_symbol_expr(function).get_identifier();
89+
auto function_iterator =
90+
goto_functions.function_map.find(function_identifier);
91+
CHECK_RETURN(function_iterator != goto_functions.function_map.end());
92+
working.emplace(
93+
function_iterator,
94+
function_iterator->second.body.instructions.begin());
95+
}
96+
97+
// add the next location to the working set
98+
working.emplace(loc.function_it, std::next(loc.target));
99+
}
100+
else
101+
{
102+
auto &body = loc.function_it->second.body;
103+
104+
for(auto successor : body.get_successors(loc.target))
105+
working.emplace(loc.function_it, successor);
106+
}
107+
}
108+
109+
return fixpoint;
110+
}
111+
112+
/// Proven assertions after refuted fatal assertions
113+
/// are marked as UNKNOWN.
114+
void propagate_fatal_to_proven(
115+
propertiest &properties,
116+
const goto_functionst &goto_functions)
117+
{
118+
// Iterate to find refuted fatal assertions. Anything reachalble
119+
// from there is a 'fatal loc'.
120+
loc_sett fatal_locs;
121+
122+
for(auto function_it = goto_functions.function_map.begin();
123+
function_it != goto_functions.function_map.end();
124+
function_it++)
125+
{
126+
auto &body = function_it->second.body;
127+
for(auto target = body.instructions.begin();
128+
target != body.instructions.end();
129+
target++)
130+
{
131+
if(target->is_assert() && target->source_location().property_fatal())
132+
{
133+
auto id = target->source_location().get_property_id();
134+
auto property = properties.find(id);
135+
CHECK_RETURN(property != properties.end());
136+
137+
// Status?
138+
if(property->second.status == property_statust::FAIL)
139+
{
140+
fatal_locs.emplace(function_it, target);
141+
}
142+
}
143+
}
144+
}
145+
146+
// Saturate fixpoint.
147+
auto fixpoint = reachable_fixpoint(fatal_locs, goto_functions);
148+
149+
// Now mark PASS assertions as UNKNOWN.
150+
for(auto &loc : fixpoint)
151+
{
152+
if(loc.target->is_assert())
153+
{
154+
auto id = loc.target->source_location().get_property_id();
155+
auto property = properties.find(id);
156+
CHECK_RETURN(property != properties.end());
157+
158+
// Status?
159+
if(property->second.status == property_statust::PASS)
160+
{
161+
property->second.status = property_statust::UNKNOWN;
162+
}
163+
}
164+
}
165+
}
166+
167+
void propagate_fatal_assertions(
168+
propertiest &properties,
169+
const goto_functionst &goto_functions)
170+
{
171+
propagate_fatal_to_proven(properties, goto_functions);
172+
}

‎src/goto-checker/fatal_assertions.h

+23
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
/*******************************************************************\
2+
3+
Module: Fatal Assertions
4+
5+
Author: Daniel Kroening, [email protected]
6+
7+
\*******************************************************************/
8+
9+
/// \file
10+
/// Fatal Assertions
11+
12+
#ifndef CPROVER_GOTO_CHECKER_FATAL_ASSERTIONS_H
13+
#define CPROVER_GOTO_CHECKER_FATAL_ASSERTIONS_H
14+
15+
#include "properties.h"
16+
17+
class goto_functionst;
18+
19+
/// Proven assertions after refuted fatal assertions
20+
/// are marked as UNKNOWN.
21+
void propagate_fatal_assertions(propertiest &, const goto_functionst &);
22+
23+
#endif // CPROVER_GOTO_CHECKER_FATAL_ASSERTIONS_H

‎src/util/irep_ids.def

+1
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ IREP_ID_ONE(line)
2626
IREP_ID_ONE(column)
2727
IREP_ID_ONE(comment)
2828
IREP_ID_ONE(property_class)
29+
IREP_ID_ONE(property_fatal)
2930
IREP_ID_ONE(property_id)
3031
IREP_ID_ONE(function)
3132
IREP_ID_ONE(mathematical_function)

‎src/util/source_location.h

+13
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,11 @@ class source_locationt:public irept
9696
return find(ID_basic_block_source_lines);
9797
}
9898

99+
bool property_fatal() const
100+
{
101+
return get_bool(ID_property_fatal);
102+
}
103+
99104
void set_file(const irep_idt &file)
100105
{
101106
set(ID_file, file);
@@ -163,6 +168,14 @@ class source_locationt:public irept
163168
add(ID_basic_block_source_lines, std::move(source_lines));
164169
}
165170

171+
void property_fatal(bool _property_fatal)
172+
{
173+
if(_property_fatal)
174+
set(ID_property_fatal, true);
175+
else
176+
remove(ID_property_fatal);
177+
}
178+
166179
void set_hide()
167180
{
168181
set(ID_hide, true);

0 commit comments

Comments
 (0)