Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gateway/API: v2: Millisecond accurate Retry-After by reading the JSON body #153

Open
diamondburned opened this issue Oct 28, 2020 · 0 comments
Open

Gateway/API: v2: Millisecond accurate Retry-After by reading the JSON body #153

diamondburned opened this issue Oct 28, 2020 · 0 comments

Comments

@diamondburned
Copy link
Owner

v8 changes now have seconds in the Retry-After header instead of milliseconds, meaning the rate limiting is now less accurate. We need to read the JSON body for the seconds as a floating point number.

The Limiter API needs to read a body as well now.
diamondburned added a commit that referenced this issue Oct 28, 2020
@diamondburned
API: V8 breaking rate limit changes
2af51c9 
This commit updates Retry-After to be seconds-accurate instead of the
previous millisecond-accurate. Another issue (#153) is opened to get a
more accurate number, which is in the JSON body instead of the header.

This commit also removed the rate limit precision header. It also uses a
more accurate calculation algorithm to derive the reset time.
@switchupcb switchupcb mentioned this issue Jul 27, 2022
Closed
@ayn2op ayn2op mentioned this issue Sep 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(api): parse Retry-After header as float
1 participant
@diamondburned