You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This problem mostly occurrs when API.ai is down (so should not be a big deal as I hope it is not that often down :D), but still it would be helpful to have a more intuitive exception raised.
Further down in apiai-ruby-cllient the problem is that fail_or_return_response_body(response.code, response_body) already takes the parsed response as argument.
apiai-ruby-client should probably only call #parse if it knows it's a json response.
Is this anything we should improve? If yes I will try to create a pr for it.
The text was updated successfully, but these errors were encountered:
When API.ai does not respond with json calling
#parse
on a HTTP response raises an exception as no other Mime Type handler is registered yet. (HTTP implements json handler as default: https://github.com/httprb/http/blob/master/lib/http/mime_type/json.rb)This problem mostly occurrs when API.ai is down (so should not be a big deal as I hope it is not that often down :D), but still it would be helpful to have a more intuitive exception raised.
Further down in apiai-ruby-cllient the problem is that
fail_or_return_response_body(response.code, response_body)
already takes the parsed response as argument.apiai-ruby-client should probably only call
#parse
if it knows it's a json response.Is this anything we should improve? If yes I will try to create a pr for it.
The text was updated successfully, but these errors were encountered: