Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this really only for Slack Bots? #5

Open
jay-jlm opened this issue Jan 19, 2017 · 8 comments
Open

Is this really only for Slack Bots? #5

jay-jlm opened this issue Jan 19, 2017 · 8 comments

Comments

@jay-jlm
Copy link

jay-jlm commented Jan 19, 2017

Because if it's not. the readme text is very misleading.

@xVir
Copy link
Contributor

xVir commented Jan 20, 2017

Hi @jay-at-avido

I tried to make it universal, but checked it only with Slack. So, any suggestions are welcome.

Thanks!

@jay-jlm
Copy link
Author

jay-jlm commented Jan 20, 2017

Well, then changing it to read:
"Utility lib for creating bots. So far only tested with Slack"
would be more accurate.

I just fear a lot of ppl would just dismiss this lib right away for being Slack only, so please consider changing the text.
Thank you

@jay-jlm
Copy link
Author

jay-jlm commented Jan 20, 2017

Actually reading the code I see there's some code that is specific for Slack, like in line 60.

@xVir
Copy link
Contributor

xVir commented Jan 23, 2017

Actually reading the code I see there's some code that is specific for Slack, like in line 60.

Yes, but it is optional

"Utility lib for creating bots. So far only tested with Slack"

Fixed!

Thanks @jay-at-avido!

@Abgaryan
Copy link

Abgaryan commented Dec 6, 2017

Is this working with facebook bot?

@xVir
Copy link
Contributor

xVir commented Dec 8, 2017

It was made for Slack, but probably it works for Facebook too...

@Abgaryan
Copy link

Abgaryan commented Dec 8, 2017

It doesn't work with facebook bot.

@mhjb
Copy link

mhjb commented Jan 12, 2018

Works with my Facebook bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants