Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unreleased packages should still trigger dependent releases #142

Open
saiichihashimoto opened this issue Apr 25, 2023 · 1 comment
Open

Comments

@saiichihashimoto
Copy link

If the dependency of packages is A depends on B depends on C, then a change in C triggers a release in A & B, which is good. The issue is if C isn't a package that gets released, eg it's a private package and we use --ignore-private-packages. I don't want to release it, but I still want changes in C to trigger a release in A & B. The list of packages that get released and the list of packages that could trigger a new release shouldn't necessarily be one-to-one. As of now, I'm forced to release C just so A & B are updated.

@saiichihashimoto saiichihashimoto changed the title ignore-private-packages ignores too much. Unreleased packages should still trigger dependent releases Apr 25, 2023
@saiichihashimoto
Copy link
Author

As an example, my monorepo has a @scope/tsconfig package and other internal packages that aren't intended to be released, but are used by other packages that are released. If I update any of the internal packages in a patch, minor, or major way, the external packages should definitely trigger a semantic release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant