diff --git a/src/visualizations/.eslintrc b/src/visualizations/.eslintrc index f8259534e..ce5078472 100644 --- a/src/visualizations/.eslintrc +++ b/src/visualizations/.eslintrc @@ -1,7 +1,5 @@ { "rules": { - "max-params": "off", - // TODO: switch back on before merging - "no-unused-vars": "off" + "max-params": "off" } } diff --git a/src/visualizations/config/adapters/dhis_highcharts/customSVGOptions/singleValue/renderer/renderSingleValueSVG.js b/src/visualizations/config/adapters/dhis_highcharts/customSVGOptions/singleValue/renderer/renderSingleValueSVG.js index 21f4ea398..715075df2 100644 --- a/src/visualizations/config/adapters/dhis_highcharts/customSVGOptions/singleValue/renderer/renderSingleValueSVG.js +++ b/src/visualizations/config/adapters/dhis_highcharts/customSVGOptions/singleValue/renderer/renderSingleValueSVG.js @@ -6,7 +6,7 @@ import { DynamicStyles } from './styles.js' export function renderSingleValueSVG() { const color = this.title.styles.color - const { dashboard, formattedValue, icon, subText } = + const { /* dashboard, */ formattedValue, icon, subText } = this.userOptions.customSVGOptions const dynamicStyles = new DynamicStyles() const valueElement = this.renderer diff --git a/src/visualizations/config/adapters/dhis_highcharts/title/__tests__/singleValue.spec.js b/src/visualizations/config/adapters/dhis_highcharts/title/__tests__/singleValue.spec.js index 4f5843c5d..bc8022f81 100644 --- a/src/visualizations/config/adapters/dhis_highcharts/title/__tests__/singleValue.spec.js +++ b/src/visualizations/config/adapters/dhis_highcharts/title/__tests__/singleValue.spec.js @@ -1,25 +1,24 @@ -import { VIS_TYPE_SINGLE_VALUE } from '../../../../../../modules/visTypes.js' -import getSingleValueTitle from '../singleValue.js' +import { getSingleValueTitleText } from '../singleValue.js' jest.mock('../../../../../util/getFilterText', () => () => 'The filter text') describe('getSingleValueTitle', () => { it('returns empty title when flag hideTitle exists', () => { - expect(getSingleValueTitle({ hideTitle: true })).toEqual('') + expect(getSingleValueTitleText({ hideTitle: true })).toEqual('') }) it('returns the title provided in the layout', () => { const title = 'The title was already set' - expect(getSingleValueTitle({ title })).toEqual(title) + expect(getSingleValueTitleText({ title })).toEqual(title) }) it('returns null when layout does not have columns', () => { - expect(getSingleValueTitle({})).toEqual('') + expect(getSingleValueTitleText({})).toEqual('') }) it('returns the filter text based on column items', () => { expect( - getSingleValueTitle({ + getSingleValueTitleText({ columns: [ { items: [{}], @@ -32,7 +31,7 @@ describe('getSingleValueTitle', () => { describe('not dashboard', () => { it('returns filter text as title', () => { expect( - getSingleValueTitle( + getSingleValueTitleText( { columns: [ { @@ -50,7 +49,9 @@ describe('getSingleValueTitle', () => { describe('dashboard', () => { it('returns empty string', () => { - expect(getSingleValueTitle({ filters: {} }, {}, true)).toEqual('') + expect(getSingleValueTitleText({ filters: {} }, {}, true)).toEqual( + '' + ) }) }) }) diff --git a/src/visualizations/config/generators/highcharts/index.js b/src/visualizations/config/generators/highcharts/index.js index f3222b257..731905aaf 100644 --- a/src/visualizations/config/generators/highcharts/index.js +++ b/src/visualizations/config/generators/highcharts/index.js @@ -6,7 +6,6 @@ import HNDTD from 'highcharts/modules/no-data-to-display' import HOE from 'highcharts/modules/offline-exporting' import HPF from 'highcharts/modules/pattern-fill' import HSG from 'highcharts/modules/solid-gauge' -import renderSingleValueSvg from './renderSingleValueSvg/index.js' // apply HM(H)