Fix wrong index point addition in polygon geometries

Withalion · nyalldawson · commit 54607d3138a1 · 2025-02-27T07:53:52.000+10:00
diff --git a/src/3d/qgsrubberband3d.cpp b/src/3d/qgsrubberband3d.cpp
@@ -315,7 +315,7 @@ void QgsRubberBand3D::addPoint( const QgsPoint &pt )
   if ( QgsPolygon *polygon = qgsgeometry_cast<QgsPolygon *>( mGeometry.constGet() ) )
   {
     QgsLineString *exteriorRing = qgsgeometry_cast<QgsLineString *>( polygon->exteriorRing() );
-    const int lastVertexIndex = exteriorRing->numPoints() - 2;
+    const int lastVertexIndex = exteriorRing->numPoints() - 1;
     exteriorRing->insertVertex( QgsVertexId( 0, 0, lastVertexIndex ), pt );
   }
   else if ( QgsLineString *lineString = qgsgeometry_cast<QgsLineString *>( mGeometry.constGet() ) )

Original file line number	Diff line number	Diff line change
`@@ -315,7 +315,7 @@ void QgsRubberBand3D::addPoint( const QgsPoint &pt )`
`315`	`315`	`if ( QgsPolygon polygon = qgsgeometry_cast<QgsPolygon >( mGeometry.constGet() ) )`
`316`	`316`	`{`
`317`	`317`	`QgsLineString exteriorRing = qgsgeometry_cast<QgsLineString >( polygon->exteriorRing() );`
`318`		`- const int lastVertexIndex = exteriorRing->numPoints() - 2;`
	`318`	`+ const int lastVertexIndex = exteriorRing->numPoints() - 1;`
`319`	`319`	`exteriorRing->insertVertex( QgsVertexId( 0, 0, lastVertexIndex ), pt );`
`320`	`320`	`}`
`321`	`321`	`else if ( QgsLineString lineString = qgsgeometry_cast<QgsLineString >( mGeometry.constGet() ) )`