From 74b31b7ca0272ab1f3224860058cf243da8af74f Mon Sep 17 00:00:00 2001 From: Dhafin Rayhan Date: Thu, 18 Apr 2024 23:18:31 +0700 Subject: [PATCH 1/2] Add rule: avoid_dynamic_calls --- analysis_options.yaml | 1 + lib/services/api/api_client.dart | 2 ++ lib/services/api/mock/mocked_api_client_repository.dart | 2 ++ 3 files changed, 5 insertions(+) diff --git a/analysis_options.yaml b/analysis_options.yaml index a3c08f7..ba04d05 100644 --- a/analysis_options.yaml +++ b/analysis_options.yaml @@ -10,6 +10,7 @@ analyzer: - custom_lint linter: rules: + - avoid_dynamic_calls - avoid_void_async - directives_ordering - prefer_relative_imports diff --git a/lib/services/api/api_client.dart b/lib/services/api/api_client.dart index 20fc6ef..661f9fb 100644 --- a/lib/services/api/api_client.dart +++ b/lib/services/api/api_client.dart @@ -1,3 +1,5 @@ +// ignore_for_file: avoid_dynamic_calls + import 'package:dio/dio.dart'; import '../../features/auth/models/login.dart'; diff --git a/lib/services/api/mock/mocked_api_client_repository.dart b/lib/services/api/mock/mocked_api_client_repository.dart index 946ee12..33d5d9d 100644 --- a/lib/services/api/mock/mocked_api_client_repository.dart +++ b/lib/services/api/mock/mocked_api_client_repository.dart @@ -1,3 +1,5 @@ +// ignore_for_file: avoid_dynamic_calls + part of 'mocked_api_client.dart'; typedef _ResponseData = Map; From 9f4c97607f258742d2be011163f7053c8fc7d577 Mon Sep 17 00:00:00 2001 From: Dhafin Rayhan Date: Thu, 18 Apr 2024 23:18:52 +0700 Subject: [PATCH 2/2] Add rule: comment_references --- analysis_options.yaml | 1 + lib/utils/hooks.dart | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/analysis_options.yaml b/analysis_options.yaml index ba04d05..4d4692c 100644 --- a/analysis_options.yaml +++ b/analysis_options.yaml @@ -12,6 +12,7 @@ linter: rules: - avoid_dynamic_calls - avoid_void_async + - comment_references - directives_ordering - prefer_relative_imports - sort_pub_dependencies diff --git a/lib/utils/hooks.dart b/lib/utils/hooks.dart index 46c0a34..e98b578 100644 --- a/lib/utils/hooks.dart +++ b/lib/utils/hooks.dart @@ -7,8 +7,8 @@ typedef AsyncTask = ({ bool hasError, }); -/// Creates a hook that provides a [snapshot] of the current asynchronous task passed -/// to [pending] and a [hasError] value. +/// Creates a hook that provides an [AsyncSnapshot] of the pending asynchronous +/// task and an error flag. AsyncTask useAsyncTask() { final pending = useState?>(null); final snapshot = useFuture(pending.value);