Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement comparison methods #5

Closed
rlskoeser opened this issue Nov 9, 2022 · 1 comment
Closed

implement comparison methods #5

rlskoeser opened this issue Nov 9, 2022 · 1 comment
Assignees

Comments

@rlskoeser
Copy link
Member

implement greater than / less than rich comparison methods for both objects

For reference python documentation:
https://docs.python.org/3.9/reference/datamodel.html#object.__lt__

We need to decide what to return in cases where gt/lt can't be determined — maybe a defined constant in undate.undate ? Documentation says we can return

NotImplemented in the case of a false comparison
... but it's not clear to me if that would make sense in this case or not.

test cases should include individual dates and date ranges, dates that can be compared and that can't; would also be nice to see how sorting works (or doesn't)

@rlskoeser rlskoeser changed the title undate and undate interval comparison methods implement comparison methods Nov 9, 2022
@rlskoeser rlskoeser self-assigned this Oct 27, 2023
@rlskoeser
Copy link
Member Author

comparison methods implemented in #65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant