Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support backups on replicas #6

Open
michaelglass opened this issue Feb 28, 2021 · 3 comments
Open

support backups on replicas #6

michaelglass opened this issue Feb 28, 2021 · 3 comments

Comments

@michaelglass
Copy link

in order to support gh-ost's need for a MySQL binlog, we want to optionally enable 1-day backups on a replica.

@michaelglass
Copy link
Author

whoops, wrong repo. Actually happy to push here or our fork. you tell me, @dgtized

@dgtized
Copy link
Owner

dgtized commented Mar 1, 2021

Happy to accept pull requests, would much prefer knowledge that current version is in active use, but pretty sure my version is ahead of your fork and slightly diverged. Specifically that the current version here also supports exporting a minimal IAM policy to allow stack-mitosis to run, which might be useful on your end, but on your fork it looks like you hardcoded a different timeout (which I intended to add as a flag at some point).

With regards to the requested feature, by default stack-mitosis enables backups on every replica that also has children. However, it can trivially enable backups on replicas if the original replica already has backups enabled. I believe that should be added to https://github.com/dgtized/stack-mitosis/blob/master/src/stack_mitosis/lookup.clj#L115 and then remove the special case in https://github.com/dgtized/stack-mitosis/blob/master/src/stack_mitosis/planner.clj#L58. That behavior is used now to transfer any existing modifications to any instance in the stack to any copies. If that behavior is also applied for BackupRetentionPeriod, then any replicas that have backups before the clone will have it after as well, even if they don't strictly require it for the clone operation.

Let me know how you would like to proceed.

@dgtized dgtized reopened this Mar 1, 2021
@dgtized
Copy link
Owner

dgtized commented Mar 1, 2021

Also I think putting it in post-create-replica-attributes would also correctly copy custom values of BackupRetentionPeriod like 2, or 30. So I think that's better anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants