Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT]: Layer Dockerfile to Improve Build Time #86

Open
dgrebb opened this issue Dec 31, 2023 · 0 comments
Open

[FEAT]: Layer Dockerfile to Improve Build Time #86

dgrebb opened this issue Dec 31, 2023 · 0 comments
Milestone
Docker Enhancements

Comments

@dgrebb
Copy link
Owner

dgrebb commented Dec 31, 2023

Problem

Docker builds take a long time.

Solution

Layer the docker image so a majority is cached before building the BackstopJS meat.

The layering should be easily overridden with a new npm script via docker buildx build --no-cache or whatever.

Layers

Each of these will be cacheable except the last, which will always get latest backstop, playwright, and puppeteer.

  • set up the OS and deps
  • set up npm deps
  • install backstop, playwright, and docker fresh
@dgrebb dgrebb self-assigned this Dec 31, 2023
@dgrebb dgrebb removed their assignment Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Docker Enhancements
Development

No branches or pull requests
1 participant
@dgrebb