Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation]: The description of the incremental backup method is misleading #2060

Open
ljfuyuan opened this issue May 22, 2024 · 0 comments
Labels
area/documentation Documentation related issues.

Comments

@ljfuyuan
Copy link

What version of Badger is the target?

V4.2.0

Documentation.

The Backup method is misleading in its description of incremental backup. The description says returns a timestamp (version) indicating the version of last entry that is dumped, which after incrementing by 1 can be passed into later invocation to generate incremental backup

But to actually achieve incremental backup, you need to pass the value directly without +1 first

Additional information.

When I test incremental backup, if I add 1 to the version returned by Backup(writer,0), some data will always be missed. If I use the version directly, I can get all the data correctly.

@ljfuyuan ljfuyuan added the area/documentation Documentation related issues. label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Documentation related issues.
Development

No branches or pull requests

1 participant