valid? method not working as expected

[pavan-itd]

It should return false if the country code is not correct.

ValidatesZipcode.valid?('Sw1A 2aA', 'UKXXXXX')
# => true

[dgilperez]

This is so by design @pavan-itd , because we don't have a validation for all country code. So instead of failing all (potentially right) zipcodes for a country code we don't have support for, we just give it a free pass.

In your case, the country code is obviously wrong, so we may raise a different exception (but I'd be hesitant to do so, at least we should mark that as a breaking change) or maybe return nil instead of false (again, I am not happy about that)

What do you think? Maybe adding a note to the docs? Do you care to open a PR in that case?