-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit Tests and CI #8
Comments
The CI file in https://github.com/dfki-ric/ugv_nav4d/blob/main/.gitlab-ci.yml is using Gitlab format. Presumably, it's from |
Build CI: Added github actions based build CI Unit Testing: The current tests test basic functionality of the planner. If you want something else then can you point me to an example implementation on another library? Thanks! |
Some C++ examples: https://github.com/tbrown122387/pf/tree/master/test https://github.com/kdm9/libqcpp/tree/master/src/tests Both of these are JOSS C++ libraries |
The tests are located here: https://github.com/dfki-ric/ugv_nav4d/tree/main/src/test @haider8645: Add the TESTS_ENABLED=ON cmake option, ply download and running the tests in the github action. |
Thanks @planthaber but that's what I've already linked in the OP. As mentioned, some form of unit test would be better (there's only one file in the folder, contains only integration test, i.e., end-to-end test). E.g. From a quick glance, (non-exhaustive list) your repo has things like Dijkstra algorithm, EnvironmentXYZTheta, compute motion, etc. These are individual item can be use some form tests. |
uploaded the ply files to zenodo. They just need to be added to our organization by the curators and then can remove the test files from repo and update docu and action |
In https://github.com/dfki-ric/ugv_nav4d/blob/main/src/test/test_ugv_nav4d.cpp there contains a few google test function.
But I wouldn't call it unit testing as it's only setting up 1 scenario and tested:
Can we have some more structured unit testing in the traditional sense?
(part of openjournals/joss-reviews#6983)
The text was updated successfully, but these errors were encountered: