Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better test coverage on query functions #27

Open
cjrace opened this issue Sep 23, 2024 · 0 comments
Open

Add better test coverage on query functions #27

cjrace opened this issue Sep 23, 2024 · 0 comments
Labels
things to test Specific aspects of our data to test the package can handle
Milestone

Comments

@cjrace
Copy link
Contributor

cjrace commented Sep 23, 2024

Is your feature request related to a problem? Please describe.

Currently we don't have great test coverage of how fully a data set is retrieved.

Describe the solution you'd like

We have some easy wins here by making use of the direct CSV downloads or the CSV endpoint of the API (soon to be added) to compare a full CSV against the parsed paginated response.

Describe alternatives you've considered

Nothing else so far.

Additional context

Could use something like waldo to compare the whole data frame, though would need to consider ordering if doing this.

@cjrace cjrace added the things to test Specific aspects of our data to test the package can handle label Sep 23, 2024
@cjrace cjrace added this to the Testing sweep milestone Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
things to test Specific aspects of our data to test the package can handle
Projects
None yet
Development

No branches or pull requests

1 participant