Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing plot_roc_curve #31

Open
kaqmak opened this issue Mar 24, 2022 · 3 comments
Open

Consider removing plot_roc_curve #31

kaqmak opened this issue Mar 24, 2022 · 3 comments

Comments

@kaqmak
Copy link
Contributor

kaqmak commented Mar 24, 2022

Does the plot_roc_curve provide anything addtional than what is in Scikit-learn?
See RocCurveDisplay

From what I see, it does not.

@KPLauritzen
Copy link
Contributor

Agreed. We have been discussing if there is any value in having a consistent interface (or just a list of common plots) here. Most of the plots we do are already provided somewhere else.

Especially yellowbrick https://www.scikit-yb.org/en/latest/ has a huge overlap with the plots we are doing.

@nybyhansen
Copy link
Contributor

What do you feel @dfds-data/data-science-chapter? Should we remove this plot or let it be for now? 💀

As @KPLauritzen mentions, it could be valuable if we had the same interface for all of our plots. That way we would be able to plug them into a training component that pushes the plot artifacts to mlflow (as an example).

@KPLauritzen
Copy link
Contributor

I like the idea of having one interface for all the plots.

However, if we want this library to be installed in many projects, we will suddenly drag in many extra dependencies. Maybe we can add yellowbrick or seaborn or some other plotting library as an optional dependency?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants