Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user local screenshot generation + extension conversion #151

Open
rlasjunies opened this issue Mar 12, 2016 · 3 comments
Open

user local screenshot generation + extension conversion #151

rlasjunies opened this issue Mar 12, 2016 · 3 comments

Comments

@rlasjunies
Copy link
Contributor

Hi guys,

code sharing

As proposed on my last issue #145, here is my code to do "local" screenshots. The user click on an icon in the command bar to take a shoot, resize and store it on the local storage ...
https://github.com/rlasjunies/dewey/commit/f30bf7af62230b15a94cb9f08b58e8182359cabd

I do not think it make sense to propose you a PR as this code change an important concept. It move whole thing from 'Chrome App' to 'Chorme Extension', so it change too many things.

screenshot generation thought

I am happy to see that you are handling the server problem. But it will not for me a good reason to come back to the OFFICIAL Dewey.app anymore.

Dewey is amazing, I really like UX, Look & Feel and the feature having the screenshot in cards. But:

  • half of my screenshots are "intranet" (not accessible from an external website screenshooter)

  • by default Deweay.app does not replace the new tab as can do an extension "naitvely" ( ok, there is a launcher @outcoldman ;-) but ... )

  • I like the opportunity to "masterize" the screenshot on my cards ( I can zoom, select the zone to screen shot scrolling down)

    The 1st topic is the most critical as these bookmarks are the most complex to retrieve when needed. Just for this feature, I would prefer to maintain my own version.

    Not everything is perfect in my current implementation:

  • the screenshots are local. Can not be share among my several devices. The current size of my thumbnail is too big for the syncStorage

    I am thinking to create my own server to "synchronize" screenshots of my Dewey extension.

proposal

I would propose you:

  1. could you think to deliver 2 packages: App and Extension. Each one deliver the best of their capabilities ( in extension the capability to do local screenshot)
  2. add the capability on the "new" server to upload thumbnails made by Dewey Extension users

Of course, I would be happy to do my part of job in this additional features/activities.

@outcoldman
Copy link
Member

First of all about the (2):

  • I like the idea of generating screenshots on client side, that will simplify a lot.
  • I do not like the idea that user need to manually generate screenshots for all of his bookmarks. Some users have more than 1000 - it will take them forever.
  • Right now our server is stateless, meaning that we can recreate it and not worry about the data. Also we do not deal with any backups or sensitive data.
  • I do not think it will be right to store "intranet" screenshots on our server. Companies may not like it. Your screenshot may have some internal/sensitive company data in them. This means we will need to deal with user authentication, security and so on. Two different users may work in two different companies and both of them have intranet links http://portal, and one of them may have a news like "Our new CEO is ...".

This means:

  • generating screenshots on client side - 👍
  • storing screenshots on server side 👎

But using your idea - we may have an ability to generate screenshot on client side when server side fails. You will be able to generate all of screenshots for your intranet bookmarks manually. We can also have an ability for you to specify your own links for the screenshots, like you can host them on dropbox or S3.

About the (1):

I'm lost with all the different types of chrome extensions. It seems like we are actually using some kind of old type packaging extension, which does not support some of the new things. What are we right now, and old type of App? It seems like that new applications cannot be open in new tab, they always will be opened in new window, is that right?
It felt like that extensions do not have an access to bookmarks. Do you know if that a case?
If we will convert Dewey into extension, will we lose anything?

@rlasjunies
Copy link
Contributor Author

I understand your comments and I feel our thought are closed. I like the idea to use personal cloud folders to persist intranet screenshot.

About the chrome App / Ext. I am also lost.

My quick analysis (reminder - I am not expert, I look around ext/app since few days using Dewey):

  • extension: have access to the bookmarks, activetab(for screenshots), newTab, omnibox
  • app: does not have activetab, newtab

I identified 1 drawback with extension, the 'new tab' feature put the focus in the omnibox not in the Dewey typehead control.

I would propose to let mature the discussion on App/Ext while you are working on the server side and I will investigate the upload of "local screenshots" on personal cloud folder.

Talk to you soon ;-)

@sangdth
Copy link

sangdth commented Mar 21, 2016

I think the the idea of rlasjunies is ok. I have more than 1000+ bookmarks too, but most of the time I can use around 100+ is maximum, and the monitor is not big enough to display more than 20+ items (without scroll), so, let us masterize at least some fav bookmarks that we use often.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants