Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: SSO Login Service configuration is misaligned and prevents saving #6312

Open
2 tasks done
woopla opened this issue Jan 17, 2025 · 2 comments
Open
2 tasks done

Bug: SSO Login Service configuration is misaligned and prevents saving #6312

woopla opened this issue Jan 17, 2025 · 2 comments
Assignees
Labels
bug Something isn't working needs-triage Issue is not approved or ready-to-work on

Comments

@woopla
Copy link

woopla commented Jan 17, 2025

📜 Description

I just installed v1.0.0 using the Helm chart, and I cannot configure LDAP access. It seems to be because the YAML fields are misaligned:

Image

In all the examples I could see on your site, all the editable part is indented to be part of config.

👟 Reproduction steps

  1. Go to Global Configurations -> Authorization -> Login Services
  2. Edit the LDAP config
  3. Click on "Save" (even using the default config)

👍 Expected behavior

Clicking on 'save' should save the config and allow me to login to Devtron using LDAP.

👎 Actual Behavior

I'm getting a "Some required fields are missing" error. I also tried to properly align with the fixed part above of the editable part, but it always snaps back to where it was.

☸ Kubernetes version

KFD-based cluster running Kubernetes v.1.29.3

Cloud provider

On-prem KFD installation.

🌍 Browser

Edge

🧱 Your Environment

I tried with

  • MS Edge 131.0.2903.112
  • Google Chrome 131.0.6778.265
  • Mozilla Firefox

✅ Proposed Solution

You should either make sure that the editable fields are properly aligned, or make the whole section editable so this doesn't happen. I could have worked around the issue if I could align things myself...

👀 Have you spent some time to check if this issue has been raised before?

  • I checked and didn't find any similar issue

🏢 Have you read the Code of Conduct?

@woopla woopla added bug Something isn't working needs-triage Issue is not approved or ready-to-work on labels Jan 17, 2025
@pawan-mehta-dt
Copy link
Contributor

@woopla can you confirm whether the final rended yaml after you save is correct for dex.config key in devtron-secret in devtroncd namespace?

@woopla
Copy link
Author

woopla commented Jan 21, 2025

@pawan-mehta-dt it's empty:

> k get -n devtroncd secret/devtron-secret -o jsonpath='{.data}' | jq '."dex.config"'
""

(I checked k get -n devtroncd secret/devtron-secret -o yaml to be sure, other things like ADMIN_PASSWORD are there as expected).

It's refusing to save the config because of this "missing" field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-triage Issue is not approved or ready-to-work on
Projects
None yet
Development

No branches or pull requests

4 participants