ext/pcntl: Fix pcntl_setcpuaffinity exception type for invalid cpu id.

devnexen · devnexen · commit 8867cfae9cb2 · 2025-01-14T21:06:57.000Z
found while working [on the doc](php/doc-en#4346).
diff --git a/ext/pcntl/pcntl.c b/ext/pcntl/pcntl.c
@@ -1721,7 +1721,7 @@ PHP_FUNCTION(pcntl_setcpuaffinity)
 				cpu = (zend_long)tmp;
 			} else {
 				zend_string *wcpu = zval_get_string_func(ncpu);
-				zend_argument_value_error(2, "cpu id invalid type (%s)", ZSTR_VAL(wcpu));
+				zend_argument_type_error(2, "cpu id invalid type (%s)", ZSTR_VAL(wcpu));
 				zend_string_release(wcpu);
 				PCNTL_CPU_DESTROY(mask);
 				RETURN_THROWS();
diff --git a/ext/pcntl/tests/pcntl_cpuaffinity.phpt b/ext/pcntl/tests/pcntl_cpuaffinity.phpt
@@ -48,7 +48,7 @@ try {
 
 try {
 	pcntl_setcpuaffinity(null, [1, array(1)]);
-} catch (\ValueError $e) {
+} catch (\TypeError $e) {
 	echo $e->getMessage();
 }
 ?>

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ try {`
`48`	`48`
`49`	`49`	`try {`
`50`	`50`	`pcntl_setcpuaffinity(null, [1, array(1)]);`
`51`		`-} catch (\ValueError $e) {`
	`51`	`+} catch (\TypeError $e) {`
`52`	`52`	`echo $e->getMessage();`
`53`	`53`	`}`
`54`	`54`	`?>`