Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two Coverage Tests - check is overwritten #7

Open
ulfgebhardt opened this issue Apr 13, 2021 · 2 comments · May be fixed by #8
Open

Two Coverage Tests - check is overwritten #7

ulfgebhardt opened this issue Apr 13, 2021 · 2 comments · May be fixed by #8

Comments

@ulfgebhardt
Copy link

Two Coverage Tests - check is overwritten

image

Both front- and backend use this github action. Both succeed, but overwrite the other. Therefore I cannot require both as merge requirement.

Possible solution:

  • Auto-generate name if a check with the same name already exists: Coverage, Coverage-1, Coverage-2
  • Allow Name-Definition in the configuration name: Coverage-Backend, name: Coverage-WebApp
  • ???
@ulfgebhardt
Copy link
Author

Something like this - sadly am not well versed in ruby.
CHECK_NAME = @github_data[:name] || 'Coverage'

The @github_data is not available there tho.

@ulfgebhardt ulfgebhardt linked a pull request Apr 14, 2021 that will close this issue
2 tasks
@ulfgebhardt
Copy link
Author

I implemented this. You can use https://github.com/webcraftmedia/coverage-check-action . There is also a PR #8 on this Repo, but stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant