-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some SASS changes #19
Comments
Hi, |
You probably need a codepen example otherwise it is difficult to debug it without seeing the code. In my grid I see this:
BTW, don't use my fork of gridlex because it may have bugs, the change from max-width to min-width is definitely a breaking change ;) |
I guess its okay then. I definitely think changing max-width to min-width would be better too. Thumbs up for the fork tho! |
Hi! For the errors.... I know :( Not push yet.... but I will. |
Hi, I have forked your repo and added some changes to the SASS version.
Now the grid is generated with a
for
loop and you can specify how many columns you want it to be. I can't send a pull request because there are a lot more changes, but if you are interested in the changes, the repo is here. I think I'll probably rename my fork as I am going to add breaking changes (changing the media queries frommax-width
tomin-width
, as I think it is more intuitive and it is mobile-first).BTW, there are several errors here and here. Also here.
The text was updated successfully, but these errors were encountered: