Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some SASS changes #19

Open
microcipcip opened this issue Aug 11, 2016 · 4 comments
Open

Some SASS changes #19

microcipcip opened this issue Aug 11, 2016 · 4 comments

Comments

@microcipcip
Copy link

microcipcip commented Aug 11, 2016

Hi, I have forked your repo and added some changes to the SASS version.
Now the grid is generated with a for loop and you can specify how many columns you want it to be. I can't send a pull request because there are a lot more changes, but if you are interested in the changes, the repo is here. I think I'll probably rename my fork as I am going to add breaking changes (changing the media queries from max-width to min-width, as I think it is more intuitive and it is mobile-first).

BTW, there are several errors here and here. Also here.

@nickngqs
Copy link

Hi,
I like how you change to a mobile first approach. However, it seems the glGutter width is not working for my side. Any idea whats is going on? It seems the padding is not compiled at all to the compiled css. Same result with devlint/gridlex.

@microcipcip
Copy link
Author

microcipcip commented Aug 17, 2016

You probably need a codepen example otherwise it is difficult to debug it without seeing the code. In my grid I see this:

[class*="grid-"][class*="-noGutter"] > [class*="col"] {
    padding: 0;
}

BTW, don't use my fork of gridlex because it may have bugs, the change from max-width to min-width is definitely a breaking change ;)

@nickngqs
Copy link

I guess its okay then. I definitely think changing max-width to min-width would be better too. Thumbs up for the fork tho!

@devlint
Copy link
Owner

devlint commented Aug 17, 2016

Hi!
Thanks @microcipcip for your fork. I've no time actually to see all your work, but I will asap!
For maxWidth/minWidth I need to see the impact before to do this, but it's a good idea.

For the errors.... I know :( Not push yet.... but I will.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants