Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alizer support for filtering devfiles by arch #1181

Open
3 tasks
thepetk opened this issue Jul 6, 2023 · 3 comments
Open
3 tasks

Add alizer support for filtering devfiles by arch #1181

thepetk opened this issue Jul 6, 2023 · 3 comments
Assignees
Labels
area/alizer Enhancement or issue related to the alizer repo lifecycle/stale Stale items. These items have not been updated for 90 days.

Comments

@thepetk
Copy link
Contributor

thepetk commented Jul 6, 2023

Which area this feature is related to?

/area alizer

Which functionality do you think we should add?

After the introduction of specific CLI parameters like --log or --min-version (#1170) we can add another filtering for --arch. This way we can match devfiles regarding their architecture.

Why is this needed? Is your feature request related to a problem?

Along other pros this will also unblock redhat-developer/odo#6805 (comment)

Detailed description:

Like --min-version and --max-version we can have another parameter which will be passed to the MatchDevfiles function:

import "github.com/redhat-developer/alizer/pkg/apis/recognizer"
filter := map[string]interface{} {
        "arch": "amd64",
}
devfiles, err := recognizer.SelectDevFilesFromTypesWithArgs("myproject", devfiles, filter)

And the overall CLI usage can be:

./alizer devfile --arch amd64 <path>

Describe the solution you'd like

The best solution for this is to pass a parameter to the URL that fetches all devfiles from registry. As a result an update inside the recognizer.GetUrlWithVersions introduced here: devfile/alizer#5

Acceptance Criteria

  • Make sure a new CLI arg is added and the new model.DevfileFilters are passed to the component_recognizer.go
  • Add test cases for those filters.
  • Add new documentation for this new cli arg.
@openshift-ci openshift-ci bot added the area/alizer Enhancement or issue related to the alizer repo label Jul 6, 2023
@thepetk thepetk self-assigned this Jul 7, 2023
Copy link

github-actions bot commented Nov 3, 2023

This issue is stale because it has been open for 90 days with no activity. Remove stale label or comment or this will be closed in 60 days.

@github-actions github-actions bot added the lifecycle/stale Stale items. These items have not been updated for 90 days. label Nov 3, 2023
@github-actions github-actions bot added the lifecycle/rotten Rotten items. These items have been stale for 60 days and are now closed. label Jan 5, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 5, 2024
@thepetk
Copy link
Contributor Author

thepetk commented Jan 5, 2024

Re-opening as it still an legit issue

@thepetk thepetk reopened this Jan 5, 2024
@michael-valdron michael-valdron removed lifecycle/stale Stale items. These items have not been updated for 90 days. lifecycle/rotten Rotten items. These items have been stale for 60 days and are now closed. labels Jan 5, 2024
Copy link

This issue is stale because it has been open for 90 days with no activity. Remove stale label or comment or this will be closed in 60 days.

@github-actions github-actions bot added the lifecycle/stale Stale items. These items have not been updated for 90 days. label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/alizer Enhancement or issue related to the alizer repo lifecycle/stale Stale items. These items have not been updated for 90 days.
Projects
Status: Done ✅
Development

No branches or pull requests

2 participants