Skip to content

Request metrics #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kylebarron opened this issue Dec 5, 2024 · 5 comments
Open

Request metrics #105

kylebarron opened this issue Dec 5, 2024 · 5 comments

Comments

@kylebarron
Copy link
Member

We should have a middleware that wraps an Arc<dyn ObjectStore> and logs request metrics (e.g. # of get, etc)
@kylebarron kylebarron added this to the 0.3.0 milestone Jan 7, 2025
@kylebarron
Copy link
Member Author

Pending apache/arrow-rs#117 it looks like this should be really easy to do.

@kylebarron kylebarron mentioned this issue Jan 7, 2025
Closed
@kylebarron kylebarron removed this from the 0.3.0 milestone Jan 7, 2025
@kylebarron
Copy link
Member Author

Well, it's not! But apache/arrow-rs#117 should still be easy!

@kylebarron
Copy link
Member Author

Relevant code in influxdb: https://github.com/influxdata/influxdb3_core/blob/main/object_store_metrics/src/lib.rs

@kylebarron kylebarron mentioned this issue Jan 15, 2025
Open
@kylebarron kylebarron added this to the 0.5.0 milestone Feb 7, 2025
@kylebarron
Copy link
Member Author

Pending the upstream client refactor apache/arrow-rs#7183 this is put on pause.

@kylebarron kylebarron removed this from the 0.5.0 milestone Feb 26, 2025
@kylebarron kylebarron mentioned this issue Mar 7, 2025
Merged
@kylebarron
Copy link
Member Author

Ref apache/arrow-rs-object-store#14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kylebarron