Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If contain any alphabet letter in between it still returns true #1

Open
miguel550 opened this issue Nov 21, 2017 · 2 comments
Open

Comments

@miguel550
Copy link

import sdq from 'sdq'

sdq.isCedula('40222075711') == sdq.isCedula('402aaaaaaaaaaaa22075711')

In the case of having alphabet letter it should return false.

@rmariuzzo
Copy link
Member

Good catch, the implementation removes everything except the digits. It should definitively behave differently. Thanks for reporting this.

@gabbanaesteban
Copy link

Fixed in #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants