Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Bump github.com/cometbft/cometbft from 0.37.5 to 0.38.11 in /tools/rosetta #543

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Aug 12, 2024

Bumps github.com/cometbft/cometbft from 0.37.5 to 0.38.11.

Release notes

Sourced from github.com/cometbft/cometbft's releases.

v0.38.11

CHANGELOG

v0.38.10

See the CHANGELOG for this release.

v0.38.9

See the CHANGELOG for this release.

v0.38.8

See the CHANGELOG for this release.

v0.38.7

See the CHANGELOG for this release.

v0.38.6

See the CHANGELOG for this release.

v0.38.5

See the CHANGELOG for this release.

v0.38.4

See the CHANGELOG for this release.

v0.38.3

See the CHANGELOG for this release.

v0.38.2

See the CHANGELOG for this release.

v0.38.1

See the CHANGELOG for this release.

v0.38.0

See the CHANGELOG for this release.

v0.38.0-rc3

See the CHANGELOG for changes available in this pre-release, but not yet officially released.

v0.38.0-rc2

See the CHANGELOG for changes available in this pre-release, but not yet officially released.

v0.38.0-rc1

See the CHANGELOG for changes available in this pre-release, but not yet officially released.

v0.38.0-alpha.2

See the CHANGELOG for changes available in this pre-release, but not yet officially released.

v0.38.0-alpha.1

See the CHANGELOG for changes available in this pre-release, but not yet officially released.

... (truncated)

Changelog

Sourced from github.com/cometbft/cometbft's changelog.

v0.38.11

August 12, 2024

This release fixes a panic in consensus where CometBFT would previously panic if there's no extension signature in non-nil Precommit EVEN IF vote extensions themselves are disabled.

It also includes a few other bug fixes and performance improvements.

BUG FIXES

  • [types] Added missing JSON tags to DuplicateVoteEvidence and LightClientAttackEvidence types (#3528)
  • [types] Only check IFF vote is a non-nil Precommit if extensionsEnabled types (#3565)

IMPROVEMENTS

  • [indexer] Fixed ineffective select break statements; they now point to their enclosing for loop label to exit (#3544)

v0.38.10

July 16, 2024

This release fixes a bug in v0.38.x that prevented ABCI responses from being correctly read when upgrading from v0.37.x or below. It also includes a few other bug fixes and performance improvements.

BUG FIXES

  • [p2p] Node respects configured max_num_outbound_peers limit when dialing peers provided by a seed node (#486)
  • [rpc] Fix an issue where a legacy ABCI response, created on v0.37 or before, is not returned properly in v0.38 and up on the /block_results RPC endpoint. (#3002)
  • [blocksync] Do not stay in blocksync if the node's validator voting power is high enough to block the chain while it is not online (#3406)

IMPROVEMENTS

  • [p2p/conn] Update send monitor, used for sending rate limiting, once per batch of packets sent (#3382)
  • [libs/pubsub] Allow dash (-) in event tags (#3401)
  • [p2p/conn] Remove the usage of a synchronous pool of buffers in secret connection, storing instead the buffer in the connection struct. This reduces the synchronization primitive usage, speeding up the code.

... (truncated)

Commits
  • e1b4453 v0.38.11 (#3684)
  • 66a0447 build(deps): Bump docker/build-push-action from 6.5.0 to 6.6.1 (#3676)
  • cd3519d build(deps): Bump bufbuild/buf-setup-action from 1.35.1 to 1.36.0 (#3675)
  • c17d1f6 fix(types): Only require extension signature if extensions are enabled (#3565)
  • f85d897 feat(mempool): add error ErrRecheckFull (backport #3654) (#3656)
  • 9de925c fix(e2e): replace docker-compose w/ docker compose (backport #3614) (#3616)
  • e9bd8a9 build(deps): Bump docker/setup-buildx-action from 3.5.0 to 3.6.1 (#3610)
  • 61ca12e build(deps): Bump docker/setup-buildx-action from 3.4.0 to 3.5.0 (#3584)
  • cba216a build(deps): Bump docker/login-action from 3.2.0 to 3.3.0 (#3585)
  • aaf83e9 build(deps): Bump docker/build-push-action from 6.4.1 to 6.5.0 (#3586)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Summary by CodeRabbit

  • New Features

    • Updated several dependencies to enhance performance and introduce new features.
  • Bug Fixes

    • Upgraded versions of key libraries, which may include important bug fixes.
  • Chores

    • Removed outdated dependencies to streamline the project requirements and improve maintenance.
    • Introduced new indirect dependencies, indicating additional functionality support.

Bumps [github.com/cometbft/cometbft](https://github.com/cometbft/cometbft) from 0.37.5 to 0.38.11.
- [Release notes](https://github.com/cometbft/cometbft/releases)
- [Changelog](https://github.com/cometbft/cometbft/blob/v0.38.11/CHANGELOG.md)
- [Commits](cometbft/cometbft@v0.37.5...v0.38.11)

---
updated-dependencies:
- dependency-name: github.com/cometbft/cometbft
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Aug 12, 2024
Copy link
Author

dependabot bot commented on behalf of github Aug 12, 2024

The following labels could not be found: A:automerge.

Copy link

coderabbitai bot commented Aug 12, 2024

Walkthrough

The recent updates to the Go project's go.mod file enhance dependency management by upgrading several key libraries, introducing performance improvements and potential new features. Significant changes include a major version update for github.com/cometbft/cometbft, alongside updates to other dependencies. Some libraries have been removed while new indirect dependencies have been added, reflecting ongoing maintenance and alignment with the latest Go ecosystem advancements.

Changes

File Change Summary
tools/rosetta/go.mod Updated several dependencies: cometbft from v0.37.5 to v0.38.11, gogoproto from v1.4.10 to v1.4.11, logfmt from v0.5.1 to v0.6.0, and others. Removed go-schnorrkel, added curve25519-voi and sync.

Poem

🐰 In the garden of code, we hop with delight,
Upgrading our friends, making futures bright.
Dependencies dance, like leaves in the breeze,
With every new version, our worries at ease.
Here’s to progress, we cheer and we play,
For the joy of the code blooms brighter each day! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 40d4293 and 20fe64f.

Files ignored due to path filters (1)
  • tools/rosetta/go.sum is excluded by !**/*.sum
Files selected for processing (1)
  • tools/rosetta/go.mod (7 hunks)
Additional comments not posted (8)
tools/rosetta/go.mod (8)

39-39: Update Gogoproto dependency.

The github.com/cosmos/gogoproto dependency has been updated from v1.4.10 to v1.4.11. Ensure that the changes in this minor version update do not introduce any unexpected behavior in your project.


54-54: Update Logfmt dependency.

The github.com/go-logfmt/logfmt dependency has been updated from v0.5.1 to v0.6.0. This update may include bug fixes or improvements. Verify that logging functionality remains intact and behaves as expected.


80-80: Update Golang Protobuf Extensions dependency.

The github.com/matttproud/golang_protobuf_extensions dependency has been updated from v1.0.2-0.20181231171920-c182affec369 to v1.0.4. Ensure that protobuf-related functionality in your project is unaffected by this update.


90-91: Update Prometheus dependencies.

The github.com/prometheus/common and github.com/prometheus/procfs dependencies have been updated to v0.42.0 and v0.12.0 respectively. These updates may include performance improvements or bug fixes. Ensure that metrics collection and related functionality are functioning correctly.


108-108: Update Multierr dependency.

The go.uber.org/multierr dependency has been updated from v1.9.0 to v1.10.0. This update may include bug fixes or improvements. Verify that error handling in your project remains consistent and effective.


83-83: Add Curve25519-voi dependency.

The github.com/oasisprotocol/curve25519-voi dependency has been newly added. This may introduce new cryptographic functionality to the project. Verify its usage and ensure it aligns with your project's security requirements.


9-9: Update CometBFT dependency.

The github.com/cometbft/cometbft dependency has been updated from v0.37.5 to v0.38.11. This update includes critical bug fixes and performance improvements. Verify that the changes in this new version are compatible with your project and that any breaking changes are addressed.


112-112: Add Golang X Sync dependency.

The golang.org/x/sync dependency has been newly added. This package provides additional synchronization primitives. Ensure that its usage is necessary and correctly implemented in the project.

Verification successful

Golang X Sync dependency is necessary and correctly implemented.

The golang.org/x/sync package is used in the ValidateGenesis function within x/gov/types/v1/genesis.go to manage goroutines for checking duplicate deposits, which justifies its inclusion. The implementation appears correct and necessary for handling concurrent operations.

  • Location: x/gov/types/v1/genesis.go
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the usage and necessity of the newly added Golang X Sync dependency.

# Test: Search for any usage of x/sync in the codebase.
# Expect: Understand the context and purpose of its introduction.
rg --type go 'x/sync'

Length of output: 77


Script:

#!/bin/bash
# Extract lines around the usage of errgroup in x/gov/types/v1/genesis.go to understand its context.
rg --type go -A 10 -B 10 'golang.org/x/sync/errgroup' x/gov/types/v1/genesis.go

Length of output: 447


Script:

#!/bin/bash
# Search for instances of errgroup usage within x/gov/types/v1/genesis.go to understand its implementation.
rg --type go 'errgroup' x/gov/types/v1/genesis.go

Length of output: 108


Script:

#!/bin/bash
# Extract lines around the usage of errGroup variable to understand its implementation and necessity.
rg --type go -A 20 -B 5 'var errGroup errgroup.Group' x/gov/types/v1/genesis.go

Length of output: 776

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Sep 27, 2024
@github-actions github-actions bot closed this Oct 4, 2024
Copy link
Author

dependabot bot commented on behalf of github Oct 4, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/go_modules/tools/rosetta/github.com/cometbft/cometbft-0.38.11 branch October 4, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Rosetta dependencies Pull requests that update a dependency file Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants