Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fiberloss method shouldn't read in file in galsim mode #90

Closed
belaa opened this issue Jun 19, 2018 · 1 comment · Fixed by #96
Closed

Fiberloss method shouldn't read in file in galsim mode #90

belaa opened this issue Jun 19, 2018 · 1 comment · Fixed by #96

Comments

@belaa
Copy link

belaa commented Jun 19, 2018

When the fiberloss method in the config file is set to galsim, initialize(config, camera_output) in instrument.py still looks for the galsim-fiber-acceptance.fits file:

RuntimeError: Cannot find file ~/Data/desimodel/0.4.2/data/throughput/galsim-fiber-acceptance.fits. May need to update desimodel svn ?

This was run on an older desimodel version 0.9.0.dev307, but this file should still only be required in fastsim mode.

@dkirkby
Copy link
Member

dkirkby commented Jul 30, 2018

Although I suggested this issue, after looking at the code I think the correct way to work without this file is to comment out this line in the config file

fast_fiber_acceptance_path: throughput/galsim-fiber-acceptance.fits

which will simply disable the fastsim mode.

I just added some comments to this section of desi.yaml to clarify this, and improved the error handling when "fastsim" is requested, but this line is commented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants