GitHub actions #156
Merged
GitHub actions #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbailey
approved these changes
Dec 11, 2020
There was a problem hiding this comment.
This looks great. The GitHub Actions are a breath of fresh air. I tested desiInstall for a tag and a branch and both worked. Minor items for consideration but not blocking factors for merging:
- Consider shortening the names of the tests in
.github/workflows/python-package.yml. When viewing the summary of tests in the github PR interface, the right side is getting cutoff (e.g. "CI / Check code style; allow failures. (ubuntu-latest, 3.8) (pull_request) Suc") even when I have the browser window maximally wide on my laptop, and the interface doesn't provide a horizontal slider. I presume that if the test failed it would be flagged obviously, but short names would help, e.g. something like "test", "coverage", "docs", "style". - very minor: could "desiInstall (package) main" be a shortcut for "desiInstall install branches/main" similar to "desiInstall (package) trunk"?
|
@sbailey, good suggestions. I'll get those in before merging. |
|
@sbailey, do you have other significant changes to desiutil planned for release 20.12? If not, I can tag desiutil after this merge. |
|
No other planned changes for desiutil for 20.12; please tag after merging. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
masteris that all branches must be explicitly labeled as such. For exampledesiInstall desiutil branches/main. Exception:desiInstall foo trunkis an abbreviation fordesiInstall foo branches/trunk.