Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

desi.lbl.gov config change may have broken desiutil unit tests #147

Closed
sbailey opened this issue Jul 21, 2020 · 4 comments · Fixed by #148
Closed

desi.lbl.gov config change may have broken desiutil unit tests #147

sbailey opened this issue Jul 21, 2020 · 4 comments · Fixed by #148
Assignees

Comments

@sbailey
Copy link
Contributor

sbailey commented Jul 21, 2020

when running pytest:

====================================================== FAILURES =======================================================
_____________________________________________ TestInstall.test_verify_url _____________________________________________

self = <desiutil.test.test_install.TestInstall testMethod=test_verify_url>

    def test_verify_url(self):
        """Test the check for a valid svn URL.
        """
        options = self.desiInstall.get_options(['-v', 'desispec', '0.1'])
        out = self.desiInstall.get_product_version()
        url = self.desiInstall.identify_branch()
        self.assertTrue(self.desiInstall.verify_url())
        self.desiInstall.product_url = 'http://desi.lbl.gov/no/such/place'
        with self.assertRaises(DesiInstallException) as cm:
>           self.desiInstall.verify_url()
E           AssertionError: DesiInstallException not raised

py/desiutil/test/test_install.py:205: AssertionError

This failure is new after the desi.lbl.gov reconfig today; the test passed in the nightly integration tests ~3am PDT on July 20.

@weaverba137
Copy link
Member

Could you say a bit more about the environment this test was run in?

@sbailey
Copy link
Contributor Author

sbailey commented Jul 21, 2020

I initially discovered it while testing a new conda environment at NERSC, then verified that it also fails on my laptop, and it failed in the standard desi master environment cronjob tests last night. e.g.

source /global/cfs/cdirs/desi/software/desi_environment.sh master
cd $DESIUTIL
pytest py/desiutil/test/test_install.py
...
        self.desiInstall.product_url = 'http://desi.lbl.gov/no/such/place'
        with self.assertRaises(DesiInstallException) as cm:
>           self.desiInstall.verify_url()
E           AssertionError: DesiInstallException not raised

py/desiutil/test/test_install.py:205: AssertionError

I would expect that it would also fail on your local machine or your own checkout of desiutil at NERSC; I haven't found anywhere that it does work since the desi.lbl.gov Cloudflare changes yesterday.

@weaverba137
Copy link
Member

OK. Just in case, could you also give the Python version?

@sbailey
Copy link
Contributor Author

sbailey commented Jul 21, 2020

Current default that you would get from cutting-and-pasting the above: python 3.6.6

My laptop default environment: python 3.6.7

Test environment where I first discovered the problem: python 3.8.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants