Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune contaminant densities #285

Closed
sbailey opened this issue Feb 27, 2018 · 3 comments
Closed

Tune contaminant densities #285

sbailey opened this issue Feb 27, 2018 · 3 comments
Assignees
Labels

Comments

@sbailey
Copy link
Contributor

sbailey commented Feb 27, 2018

Ironically, after 120+ commits, the "fix-densities" branch didn't tune the contaminant densities; see PR #264 :) . Study and tune those densities. The most egregious case is stellar contamination of BGS targets.

@sbailey sbailey added the mocks label Feb 27, 2018
@moustakas
Copy link
Member

For the record -- and in my defense! -- the fix-densities branch was so named to fix the too-low QSO+Lya target densities (originally started in #192 in June 2017), which we did. Tuning contaminant densities have always been problematic because of inadequacies of our mocks (although the Buzzard mocks -- see #249 -- should help address this issue). Finally, the refactor in #264 was designed to much more easily accommodate including contaminants and other desired improvements and features.

@moustakas
Copy link
Member

The Lya working group has started collecting some very useful notes and ideas for simulating QSO contaminants, which I'm linking here for reference---
https://desi.lbl.gov/trac/wiki/LymanAlphaWG/SimulateQuasarTargets

@moustakas
Copy link
Member

Now tracking this issue in #401; closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants