You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Ironically, after 120+ commits, the "fix-densities" branch didn't tune the contaminant densities; see PR #264 :) . Study and tune those densities. The most egregious case is stellar contamination of BGS targets.
The text was updated successfully, but these errors were encountered:
For the record -- and in my defense! -- the fix-densities branch was so named to fix the too-low QSO+Lya target densities (originally started in #192 in June 2017), which we did. Tuning contaminant densities have always been problematic because of inadequacies of our mocks (although the Buzzard mocks -- see #249 -- should help address this issue). Finally, the refactor in #264 was designed to much more easily accommodate including contaminants and other desired improvements and features.
Ironically, after 120+ commits, the "fix-densities" branch didn't tune the contaminant densities; see PR #264 :) . Study and tune those densities. The most egregious case is stellar contamination of BGS targets.
The text was updated successfully, but these errors were encountered: