Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different order of (estimates, reference) in SISDR Loss forward #96

Open
seastar105 opened this issue Aug 17, 2023 · 0 comments
Open

Different order of (estimates, reference) in SISDR Loss forward #96

seastar105 opened this issue Aug 17, 2023 · 0 comments

Comments

@seastar105
Copy link

while other metrics accept (estimates, reference) in function call, SISDR takes (reference, estimates) in function call which makes confusing and easy-to-mistake. need change!

def forward(self, x: AudioSignal, y: AudioSignal):
eps = 1e-8
# nb, nc, nt
if isinstance(x, AudioSignal):
references = x.audio_data
estimates = y.audio_data
else:
references = x
estimates = y

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant