Skip to content

Latest commit

 

History

History
37 lines (23 loc) · 1.49 KB

CONTRIBUTING.md

File metadata and controls

37 lines (23 loc) · 1.49 KB
Raw

Contributing

By participating in this project, you agree to abide by the thoughtbot code of conduct.

Fork, then clone the repo:

git clone [email protected]/wellcometrust/platform.git

Make your change. Write a test for your change, (or the other way round).

Push to your fork and submit a pull request.

At this point you're waiting on us. We like to at least comment on pull requests within three business days. We may suggest some changes or improvements or alternatives.

Some things that will increase the chance that your pull request is accepted:

  • Ensure you appropriately lint any changes using the relevant make tasks.
  • Write a good commit message.

Pull Request process

Here are some guidelines that we follow internally when submitting PRs:

  • Open PRs as early as possible to provide visibility of work
  • PRs not ready for final review should be prefixed "[WIP]"
  • Developers should assign themselves to PRs they have contributed code changes to
  • PRs should only be approved by someone who has not contributed code changes
  • PRs should be merged by the assignees of a PR
  • RFC PRs should be approved by all non-contributing developers in the digital platform team in order to be merged
  • Developers assigned to a PR are responsible for deploying their changes after a merge