vets-api/v0.0.1428

Release 0.0.1428 ami-06e2a3a906bf9d340

bd2904c Update pdf_submit sidekiq worker to retry specific EMMS errors when s (#12483)

• Update pdf_submit sidekiq worker to retry specific EMMS errors when submitting an appeal

• unit test changes

• Catch all don't retry appeals submit worker if the error is not retryable

• added upstream http resp status member

• Changed retryable error codes to int

• added exception testing to unit test

• Merge Conflict resolution

---

Co-authored-by: michelpmcdonald michel.mcdonald@adhocteam

0561305 Mobile: Remove statsd (#12598)

• Remove statsd

• Remove necessary statsd tests

d6fc966 [57955] Add success and error logging for Form 686c. (#12569)

Add success and error logging for Form 686c.

We need to re-process years of failed Form 686c submissions. A re-processing effort depends on knowing all null claims that have been generated. Matt B. put together SQL aimed at generating reports of all null claims in a given time period. We would like to verify the accuracy of these reports. One way to do that is to log all failed submissions on our end, and then compare our counts within some time period to the counts generated by Matt B.'s reports. If the two are sufficiently similar, then we can reasonably rely on Matt B.'s report of null claims for our re-processing efforts.

To that end, I've added error logging to inform us of instances where a 686c claim or 674 claim fails to establish via BGS. We can then build a DataDog dashboard to search for and count these error logs, and compare those counts against Matt B.'s report.

I've also added success logging, and logging for the job that uploads PDFs to VBMS.

009a2af Api 24826 section 1 validation (#12603)

• Work in progress

• Update to use BRD ref data for countries, fix tests

• Add pattern for internationalPhone, add test for no mailingAddress

• Add more tests

• Rubocop fixes

• Change test variable to snake case

• Add swagger files

• Refactor validation methods to one, add tests for all attributes

• Add two more tests

• Remove prod swagger

• Remove Gemfile.lock

• Changes vars to snake case

• More Rubocop

• Add email validation pattern, test for same

• Add swagger

1d50fa6 VACMS-13585 Add feature flipper for new income limits application (#12616)

635ddc7 4745 update to Lighthouse upstream service to Mobile claims index (#12575)

• use lighthouse upstream service

4b2addc Implement Rails Cache for VAOS Facility and Clinic Calls (#12588)

• feat(vaos): add caching to mobile facility service for clinic and facility retrieval to reduce backend service calls and improve performance

• refactor(vaos): rename get_cached_provider to get_provider_with_cache for consistency and better readability

38d8c9c Fix settings key for template id (#12615)

c140618 1010EZ update SOAP response for Race/Ethnicity/Origin question (#12554)

• add demographic no check

• spec for has_demographic_no

• add demographic no json

• record demographic vcr

• add missing do

• fix veteran to races for has demographic no

• demographic no vcr

• change spec to not record

• lint

01798a6 Form 21-10210 lay-witness prefill (#12619)

• prefill scaffolding

• lint

90b7aa9 Update Benefits Intake docs with new page size limit (#12584)

vets-api/v0.0.1427

Release 0.0.1427 ami-0f97ae6d63fd35bbd

7da037d Api 26010 intake sites (#12517)

• Add BRD service (for countries)

• Add intake sites endpoint to BRD module

• update brd hostname

b8712e5 Add more debugging for Feature Toggles 500 errors (#12596)

• add more debugging

• lint

0ed96a0 Removes requires statements that were made redundant as a result of Zeitwerk (#12567)

Co-authored-by: Gia Antoniades [email protected]

93ec0da Mhv 42068 mr allergies api (#12599)

• MHV-42068: MR allergies api complete

• MHV-42068: Fix allergies_controller.rb rubocop error

• MHV-42068: rubocop newline fix

---

Co-authored-by: wright0776 [email protected]

b3197cf Properly reference first name for 1880 in progress form (#12604)

e8832c5 Only send to unauthenticated users (#12601)

9ef083d Removes unnecessary 'require_dependency' from mobile module (#12597)

Co-authored-by: Gia Antoniades [email protected]

ecd0150 fix (#12607)

88bedfd Removes unnecessary 'require_dependency' from veteran_confirmation module (#12590)

Co-authored-by: Gia Antoniades [email protected]

37c66f2 Removes "require_dependency" from va_forms module (#12583)

Co-authored-by: Gia Antoniades [email protected]

85770b2 Removes 'require_dependency' from apps_api module (#12573)

Co-authored-by: Gia Antoniades [email protected]

f3d4e81 Removes unnecessary require_dependency statement from appeals_api module (#12572)

Co-authored-by: Gia Antoniades [email protected]

1a1fc9f Removes unnecessary 'require_dependency' from openid_auth module (#12581)

Co-authored-by: Gia Antoniades [email protected]

e6e2067 Removes unnecessary 'require_dependency' from meb_api module (#12579)

Co-authored-by: Gia Antoniades [email protected]

0456408 Removes unnecessary require_dependency statement (#12577)

Co-authored-by: Gia Antoniades [email protected]

6f57dee [API-25991] Create FormBuilder worker (#12549)

0b97560 income limits data migration (#12602)

0a20295 VaNotify - Add feature flag (#12611)

11160b9 Add BDEx1 engineers to Flipper allow list (#12522)

• add BDEx1 engs to Flipper allow list

• Change seth's email to agile6.com

vets-api/v0.0.1426

Release 0.0.1426 ami-09a3246260ffa0702

cd639ea Add [email protected] to flipper admin user emails (#12563)

bbc4194 [#MHV-39259] Adding MHV FHIR-ized API calls (#12492)

• [#MHV-39259] Created some initial files

• [#MHV-39259] Require MR client

• [#MHV-39259] Merged medical records routes

• [#MHV-39259] Testing controller inheritance

• [#MHV-39259] Renaming controller

• [#MHV-39259] Added client functions to get FHIR vaccine data

• [#MHV-39259] Fix Rubocop errors

• [#MHV-39259] Refined API calls a bit

• [#MHV-39259] Fixed Rubocop error

• [#MHV-44562] Added preliminary spec tests for immunizations

• [#MHV-39259] Replace vcr cassette host with config value

• [#MHV-39259] Adding test values to test.yml

afaf411 10-10EZ - Bug: Discharge Character showing as "Other than Honorable" (#12566)

• dont prefill other for 1010ez discharge_type

• lint

• fix form profile spec

696a6e8 Bdex/57603: follow up - added more evss provider tests and local file requirement (#12561)

• bdex/57603: add more evss provider unit tests

• for fun

• bdex/57603: require dto file for rails console commands to work

• this isn't failing in the tests nor in ArgoCD.
• only affects local rails c commands

1cb5761 set csrf header before saml_callback (#12564)

95389de 58015 handle updated BTSSS success response (#12570)

f679cbb 58039 Modify test.yml with fake IDs (#12574)

Co-authored-by: kanchanasuriya [email protected]

9c8e2a4 API-26384: Fix Bug where Error Detail was Missing for "UnidentifiableMail" Appeal Submissions (#12578)

• API-26384: Fix bug where error message was missing in the case of an 'UnidentifiableMail' packet

• API-26384: Remove condition not needed

1c4c679 Fixes flakely tests. (#12586)

c188266 Api 26143 526 pdf mapper section 0 (#12562)

• Adds auto_claim to pdf generator mapper.

• Adds the mapper to the controller with passing tests.

20b3bc8 Revert "set csrf header before saml_callback (#12564)" (#12585)

This reverts commit 1cb5761.

ce92fe3 Api 26350 526 v2 526 schema description updates (#12551)

• Updates descriptions on the docs

• Updates 526 json schema file following ticket API-26350

d71d854 Add BRD service (for countries) (#12401)

• Add BRD service (for countries)

• update brd hostname

vets-api/v0.0.1425

Release 0.0.1425 ami-0624235983d326b60

b704bf1 FSR service should always submit with submit_combined_fsr irrespective of combined_financial_status_report feature flag (#12515)

b256620 API-24186 - Un-revert VBADocuments max page limit, fix upload error detail (#12545)

• Revert "Revert "API-24186 New max dimensions for Benefits Intake API (#12457)" (#12518)"

This reverts commit 3c9bbf4.

• Fix missing error detail in UploadError

a391581 Bdex/57603: EVSS Migration: rated_disabilities - match app behavior response out side of successful response (#12552)

• bdex/57603: handle Lighthouse API exceptions

• repurposed ServiceException to send back an error the controller ExceptionHandling class knows how to... handle

• bdex/57603: handle Lighthouse API exceptions

• bdex/57603: handle Lighthouse API exceptions

• bdex/57603: add more tests and documentation

• bdex/57603: finish up EVSS provider tests

• bdex/57603: revert evss provider tests for now.

• they're not THAT important...
• adding in another PR :)

• revert 403 error

• bdex/57603: remove extra variable declartion

5c54b8b Update segmented appeals API routes (#12559)

Adjusts routes in the segmented appeals APIs as follows:

• Removes old, deprecated variants which used underscores instead of
  dashes.
• Adds appealable-issues alias for contestable-issues routes -
  later, the name contestable-issues will be retired.

cc099fd Vanotify - 1880 in progress reminder (#12558)

d423952 Updated 'vets_json_schema' gem (#12534)

886dcdb Api 26250 section 0 validation part 2 (#12548)

• Adds validation, and tests for claimDate. WIP - one failing test.

• Moves json_validation above dis_comp_validations.

• Rubocop

• Adds tests for claimant cert

• Removes unneeded clause. Runs rswag rake task to add regex to claimDate on swagger doc.

vets-api/v0.0.1424

Release 0.0.1424 ami-0479438632cf8d1ca

34cfaa5 Vfep 571 - add tests for emailing spool files on staging and put contents in body of email instead of attaching (#12542)

• email spool files staging

• fix staging spool email settings

• fix rubocop errors

• rubocop errors

• Add test coverage

• fix tests and put contents inline in body instead of attachment

---

Co-authored-by: nfstern02 [email protected]
Co-authored-by: nfstern02 [email protected]

df9897b 56995 Strip dashes from valid BGS file numbers and log invalid SSNs and file numbers. (#12530)

We have been getting errors on BGS's vnp_person_create endpoint because the file number and SSN that we send over do not match. We get our file numbers from BGS and get our SSNs from MPI or another VA.gov identity provider. A mismatch may exist because MPI or BGS have the wrong SSN or file number, because BGS has an invalid file number, or because BGS has a valid file number that is incorrectly formatted.

Where MPI or BGS have the wrong file number, or where BGS has an invalid file number, all we can do is log and report the mismatches to them so they can fix the issue. Where BGS returns a valid file number that is incorrectly formatted (i.e. contains dashes and digits, instead of just digits) we can simply reformat the SSN (i.e. remove the dashes) before submitting it to BGS along with the file number. These are the aims of this PR. See the code comments for more detail.

94f361d Update danger to use actions/checkout@v3 (#12507)

154d483 [56749] Combine FSR reasons for user facing PDF (#12546)

• Aggregate FSR reasons for general purpose PDF

• Add exist check for debts in map

4322214 Update betamocks config (#12540)

c08a2ae debug line for CSRF token (#12555)

vets-api/v0.0.1423

Release 0.0.1423 ami-070fa3bd7633043fe

62bdc78 API-24827-part-3: adds validators (#12539)

• Adds validation file, base controller for json validator, and method body for 526 submit.

• Adds tests for disability comp requests

• Adds tests passing, and form_526_json_api corrections to match the schema.

• Adds missing description to schema.

8a189b2 55883 Travel Claim and Notifications Async (#12501)

• 55883 initial travel claim, notify worker code

• 55883 add spec

• 55883 update spec to add expectation for statsd and sentry

• 55883 add specs for duplicate and error response from claims

• 55883 use response codes statically

• 55883 add specs

• 55883 log only last 4 of phone number

• 55883 log last 4 correctly

da09d6f Fixing flaky spec in inherited proofing spec (#12541)

Co-authored-by: Trevor Bosaw [email protected]

8e8488a [department-of-veterans-affairs/va-virtual-agent#873] Raises error if (#12510)

• [department-of-veterans-affairs/va-virtual-agent#873] Raises error if LH call fails

Coauthored-by: [email protected]

• [department-of-veterans-affairs/va-virtual-agent#873] Defaults to correct API inputs

When calling LightHouse Sandbox from Staging vets-api, passing in the correct SSN and Email

Coauthored-by: [email protected]

• Corrected the test for error scenario

• Added new mock response for testing appeals

• [department-of-veterans-affairs/va-virtual-agent#873] PR feedback

• Added Unit test for error scenario in staging env

Co-Authored-By: Karan Krishnani [email protected]
Co-Authored-By: Joseph Hall [email protected]
Co-Authored-By: Maurice Okumu [email protected]

---

Co-authored-by: swapna-tw [email protected]
Co-authored-by: Joseph Hall [email protected]
Co-authored-by: Maurice Okumu [email protected]

f50c5be API-25718-bgs-error-handling (#12425)

• Adds method to handle bgs errors in local bgs file

• Adds initial work on shared soap error handling class; having to switch branches

• Adds java errors mapped to ruby exceptions

• Rubocop

• Adds catch in case the response is nil

• Rubocop

• Adds exception type, and provides more specific error detail mapping to exceptions

• Refactors soap error handling

• Addresses PR comments

• Addresses PR comments & rubocop

• Removes unnecessary change

• Resolves error

c78a352 API-24891 Unique spec file for Contestable Issues v0 (#12513)

• API-24891 Unique spec file for Contestable Issues v0

Splits shared contestable issues rswag examples into separate files for
Contestable Issues API v0 vs. Decision Reviews API v2

• Refactor contestable isssues docs specs

• Allow contestable issues doc spec to run under rspec

In addition to under the rswag rake tasks

vets-api/v0.0.1422

Release 0.0.1422 ami-02d3e3ab1c1e4d5d5

0e3243e [12511] Use betamocks cache dir instead of mock credential dir (#12512)

8a1b30d 56517 service type/category null value logging refactor (#12528)

• dig refactor

7614440 VAOS Implement low-level Rails caching for Provider Name (#12525)

• feat(vaos): add get_cached_provider method to retrieve cached provider data or fetch and cache it if not already cached

• test(vaos): add tests for get_cached_provider method and refactor before block to include cache and cache clearing

65daa20 Removes American Indian indicator key from demographics payload along with related tests and test data (#12397)

• First commit

• Fixed failing tests

• Fixed Gemfile.lock

• Fixed line issue

• Removed american indian flipper feature and some other unnecessary code

a3d0538 Vfep 550 - email spool files on staging (#12531)

• email spool files staging

• fix staging spool email settings

• fix rubocop errors

• rubocop errors

---

Co-authored-by: nfstern02 [email protected]

38cfb82 API-24827-part-1 Cleanup (#12537)

• Cleanup

• Adds require to failing test

30a7bed Rubocop (#12538)

338df45 [department-of-veterans-affairs/va-virtual-agent#864] Defaults appeals status to unknown (#12535)

If we encounter an appeals status type which is not recognized

Co-authored-by: Aaron Young <[email protected]>
Co-authored-by: Alex Person <[email protected]>
Co-authored-by: Helene Mccarron <[email protected]>
Co-authored-by: Kha Huynh <[email protected]>

. Co-authored-by: Maurice Okumu [email protected]
Co-authored-by: Swapna Krishnankutty [email protected]

99042c0 Migrate the form526_rapid_ready_for_decision_concern to ApiProviderFactory (#12524)

• migrate the form526_rapid_ready_for_decision_concern to apiProviderFactory

• fixed form526_submission_spec

• Fixed submit_form526_all_claim_spec

• bdex/57215: clean up unit tests

• bdex/57215: clean up unit tests

---

Co-authored-by: lightning [email protected]

vets-api/v0.0.1421

Release 0.0.1421 ami-073e8acd41586beb6

44719fa Adding a random uuid if the passed in value is nil. Just send the payload, the id is not important (#12519)

af9d6d2 5541: update openapi docs to represent new Rx endpoint statuses (#12520)

3f05791 5541 rx status tests (#12516)

• 5541: better specs for rx status handling

bcdf808 Add logingov to backend_statuses (#12521)

bb51b81 Vfep 413 - remove feature flags 5490 spool file (#12523)

• fix tests after updating json-schema to include guardian

• modify school selection and update tests

• fix Gemfile.lock

• nokogiri fix

• fixes for school selection and phone numbers

• show mobile number before home number in spool files for all forms

• updated Gemfile.lock from master

• remove feature flags 5490 spool

• updated json-schema to use vfep-511

• update gemfiles

---

Co-authored-by: nfstern02 [email protected]

265b93c Api 26160 remove uploaded attribute (#12500)

• Remove uploaded attribute

• Rubocop fixes

• Update schema, add generated swagger

3db1d6a Always set overdue to false unless it's in wwsnfy (#12480)

• Always set overdue to false unless it's in wwsnfy

• Update param

• Fix typo

• Fix guard

---

Co-authored-by: Austin Covrig [email protected]

vets-api/v0.0.1420

Release 0.0.1420 ami-02ef96de6106b0856

be90538 API-24891 Correct underscores to dashes in segmented appeals API docs (#12491)

abd3fc7 Commented out EVSSClaimBaseSerializer and Claims::Proxy rails error logs (#12508)

• Commented out EVSSClaimBaseSerializer and Claims::Proxy rails error logs

• Fixed linting

• Commented out rspec

• Uncomment one log"

• Fixed rubocop errors

---

Co-authored-by: rccassity [email protected]

ea208b4 Added Stop Codes to Type of Care Logging. (#12504)

• feat(vaos): added stop codes to type of care logging.

3c9bbf4 Revert "API-24186 New max dimensions for Benefits Intake API (#12457)" (#12518)

This reverts commit 31e75c4.

vets-api/v0.0.1419

Release 0.0.1419 ami-0798395f97f0c7cf7

31e75c4 API-24186 New max dimensions for Benefits Intake API (#12457)

• Fix benefits intake page size reporting

Previously the height and width were reversed

• API-24186 Larger max page dimensions for Benefits Intake

We've learned that pages may be up to 78 in. x 101 in., so this updates
the maximum page dimensions in the benefits intake API accordingly. This
update is behind the fetaure flag,
vba_documents_larger_page_size_limit. It obsoletes the old feature
flag vba_documents_skip_dimension_check.

• Restrict vba_documents Flipper flag usage to vba_documents module

• Add specs for CentralMail::UploadError

af52c87 5531: remove logging when attempting to cache nil (#12497)

3986519 Add params to vets-api workflow (#12473)

• Add params to vets-api workflow

• update logic for web branch

• Fix syntax error

• Fix env variable assignment

• Refinements based on vets-website testing of similar workflow

• Fix typo

• Wrong variable for expiration days

---

Co-authored-by: Curt Bonade [email protected]

f8c3f99 Add mcp notifications feature flag (#12496)

• Add mcp notifications feature flag

• Correct pundit call

882dd03 57009: temporarily remove rx logging (#12503)

• 57009: temporarily remove rx logging

• lint

2a0bead API-26059 Log durations of some sidekiq jobs (#12474)

• API-26059 Adds generic way to opt a job into benchmark logging

7a3f9e9 Forms Api: Add log for submission UUID (#12505)

• add log for uuid

• line length

a7ce62b Rename MCP notifications endpoint (#12453)

• Drop new from mcp notifications endpoint

• Update before controller hooks

• Update swagger spec