Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Island build fails with "nodeModulesDir": "auto" #2701

Closed
adamgreg opened this issue Oct 10, 2024 · 1 comment
Closed

Island build fails with "nodeModulesDir": "auto" #2701

adamgreg opened this issue Oct 10, 2024 · 1 comment

Comments

@adamgreg
Copy link
Contributor

After moving to Deno 2.0, I have added "nodeModulesDir": "auto" to my config file. That leads to a failure when building the islands via dev mode of Fresh 1.7.2. There is no problem if I remove the line from the config file, and run deno task start with either --node-modules-dir=auto or --node-modules-dir=none. I assume that the way esbuild_deno_loader is run means that the CLI arguments have no effect, while the config file does.

I think the underlying issue may be fixed a couple of weeks ago by lucacasonato/esbuild_deno_loader#141 . I've created a new issue to ask for another release: lucacasonato/esbuild_deno_loader#146 . After the release, I guess Fresh 1.x will need to update its dependency.

I've tried testing by updating the esbuild_deno_loader dep in my own GitHub fork of Fresh to use a raw GitHub URL, but that fails with an unresolved relative import.

@marvinhagemeister
Copy link
Collaborator

Resolved by #2708

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants