Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

og:image isn't great for long URLs #100

Open
ry opened this issue Feb 8, 2022 · 1 comment
Open

og:image isn't great for long URLs #100

ry opened this issue Feb 8, 2022 · 1 comment

Comments

@ry
Copy link
Member

ry commented Feb 8, 2022

https://doc.deno.land/https://googleapis.deno.dev/v1/calendar:v3.ts
Screen Shot 2022-02-08 at 9 19 13 AM

@kitsonk
Copy link
Contributor

kitsonk commented Feb 8, 2022

Is there a better suggestion? There are limitations to dynamically generating the image, we don't have a lot of information about overflow available, and there is no good CSS... There is code which tries to parse out information for known registries.

The only thing I can think of is that we don't know the registry, we use an alternative image which provides some other information, but I am not sure what other information could be provided in a case like this, as the module doesn't contain a leading JSDoc block comment with a @module which could be used to provide information about the module.

If you can describe what you would like to see in the image given the constraints that we can't take advantage of any CSS layout, basically only filling in slots within an SVG, we can try to implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants