Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: disable auto-discovery of config file for deno run <remote entrypoint> #13744

Closed
kt3k opened this issue Feb 23, 2022 · 0 comments · Fixed by #13745
Closed

Proposal: disable auto-discovery of config file for deno run <remote entrypoint> #13744

kt3k opened this issue Feb 23, 2022 · 0 comments · Fixed by #13745
Labels
suggestion suggestions for new features (yet to be agreed)

Comments

@kt3k
Copy link
Member

kt3k commented Feb 23, 2022

If the users have custom typescript settings which are incompatible with default settings (e.g. frontend typings), they will see type errors when they execute the remote Deno scripts.

For example, a user develops frontend lib. deno.json has frontend types (e.g. "lib": ["dom", "esnext"], etc). When they want to run, for example, udd command in the CI, the command throws type error because of the incompatible type settings of the auto-discovered deno.json. (This happens, for example, in hayd/deno-udd#59, and they avoid the error by removing deno.json in CI UltiRequiem/timero@56dc4ba . This doesn't look great.)

This situation doesn't make sense because deno.json is usually only for local scripts. The config is not intended to be applied to all deno programs.

So I suggest we should disable auto-discovery of config file when the command is deno run <remote entrypoint>, which fixes the above situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggestion suggestions for new features (yet to be agreed)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant